[PATCH] Visualisation of individual oxygen sensor data for CCR dives

[Jef Driesen]

On 11-05-17 14:37, Anton Lundin wrote:
> On 11 May, 2017 - Jef Driesen wrote:
>> I replaced your patch with your latest version, and updated the rest
>> of the series. Please have a look. If you are okay with the changes,
>> I'll merge them to master.
>
> LGTM.
>
> You can add my Reviewed-by: Anton Lundin <glance at acc.umu.se> tag to the
> patches if you like.

I have pushed the changes to master.

> I think its a good idea to keep the O2 sensors behind the SENSOR_AVERAGE
> ifdef for now, and try to figure out a nice scheme to expose both the
> raw sensors and the "voted average" value as different things to the
> application.

Indeed. That'll be the next step.

> The two other libdivecomputer backends emitting DC_SAMPLE_PPO2 are
> diverite_nitekq_parser and the hw_ostc_parser. The HW values are raw
> sensor values, but do you know what the diverite_nitekq_parser value
> are?

It's been a while since I reverse engineered the nitekq and I simply don't 
remember anymore. But since there is just one value, my guess is that it's 
probably the average ppo2.

Jef