Warning: Major construction work on planner ongoing

Robert Helling helling at lmu.de
Thu Nov 16 06:00:25 PST 2017


Hi,

I wish I wouldn’t have to write this message but could rather send a PR…

I have started work to make the planner thread save so we could plan in the background without holding up the UI. This of course means that it should not keep stuff in global variables but that each instance should hold its own copy of local variables. Therefore, I am going through the code and try to turn global state variables in local ones (passed around as a pointer to a struct planner_state). Unfortunately, the current state is a mess (it compiles but the planner is broken, wrong plans and also the tests fail).  My hope is this can be fixed with not too much additional work (I have already invested almost two days in this) but right now I don’t have the time (and due to a family celebration it is very unlikely that is will be resolved over the weekend).

But what I already have touches a lot of code in the planner (planner.c deco.c and also user interface .cpp related to it). So could I please ask you to hold back working on the planner over the weekend so I don’t run into a big merge problem when I hopefully have this ready early next week?

If you are interested in what I am doing, look at my threadedplanner branch on GitHub.

Best
Robert

--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20171116/a5806eff/attachment.sig>


More information about the subsurface mailing list