Scubapro Aladin Square

[Linus Torvalds]

On Thu, Nov 16, 2017 at 2:44 PM, vavincavent <vavincavent at gmail.com> wrote:
>
> In my local files it's ok for downloading and analysing of the dives!
>
> You'll find attached the files i've change.

Very good. I will try to come up with a better model for the whole USB
ID selection (because I suspect we'll have a few more models show up
eventually), but that should be trivial. I'll probably just make it an
array of "model, vendor, device" entries.

One more question: does the Square actually need that model number
query for handshaking, or is that just leftovers? IOW, what happens if
you remove these lines

        // Read the model number.
        unsigned char cmd_model[1] = {0x10};
        unsigned char res_model[1] = {0};
        status = scubapro_g2_transfer (device, cmd_model, sizeof
(cmd_model), res_model, sizeof (res_model));
        if (status != DC_STATUS_SUCCESS)
                goto error_free;

from scubapro_g2_device_open()? I suspect that change shouldn't
matter, and is just left-overs from the other trials..

            Linus