Scubapro Aladin Square

vavincavent vavincavent at gmail.com
Sat Nov 18 05:42:01 PST 2017


Linus,

I've tested, it seems to be good.
I attacched the subsubface log to show you versions of subsurface and
libdivecomputer branch.

Vincent.

Vincent.Le jeudi 16 novembre 2017 à 15:41 -0800, Linus Torvalds a
écrit :
> On Thu, Nov 16, 2017 at 3:05 PM, Linus Torvalds
> <torvalds at linux-foundation.org> wrote:
> > 
> > Very good. I will try to come up with a better model for the whole
> > USB
> > ID selection (because I suspect we'll have a few more models show
> > up
> > eventually), but that should be trivial. I'll probably just make it
> > an
> > array of "model, vendor, device" entries.
> 
> Ok, I pushed out something that *may* work for you into the
> Subsurface-branch of libdivecomputer.
> 
> It has the USB vendor/device selection array, and the model checks
> for
> the Aladin Square.
> 
> It does *not* have the extra "Read the model number" code in the
> handshake, so it's not exactly what you tested, but I suspect that
> was
> just leftovers from earlier testing and isn't actually necessary.
> 
> But I could easily be wrong, considering how nit-picky that dive
> computer was with the whole USB HID packet format.
> 
> So could you test current Subsurface-branch with no other patches?
> 
> Oh, and I just noticed that Jef had actually pushed out his changes
> to
> his branch. I should have checked before I made my changes.
> 
> Jef had picked a different name in uwatec_smart_parser.c from that
> "SQUARE" (and I agree - and like Jef, I had used ALADINSQUARE in
> scubapro_g2.c).
> 
> But I kept my USB ID array.
> 
>                    Linus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: subsurface.log
Type: text/x-log
Size: 114758 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20171118/f29bfa23/attachment-0001.bin>


More information about the subsurface mailing list