Replace repetitive code in SettingsObjectWrapper.cpp by functions?

Lubomir I. Ivanov neolit123 at gmail.com
Sat Nov 18 11:21:10 PST 2017


On 18 November 2017 at 21:17, Berthold Stoeger
<bstoeger at mail.tuwien.ac.at> wrote:
> OK, prepared such a PR.
>

as noted at the PR comments. could you run your build with `-Wall` to
see if these changes don't introduce a lot of (char *) <-> (const char
*) cast warnings?

> Thereby I noted two things:
>
> 1) In getCloudURL() in core/qthelper.cpp, the cloud_storate_email_encoded
> member is set, but it seems not to be written to disk.
>
> 2) In uploadFinished() in core/cloudstorage.cpp, the cloud_storage_password
> member is set, but it likewise seems not to be written to disk.
>

Dirk can best comment about the cloud storage.

lubomir
--


More information about the subsurface mailing list