Replace repetitive code in SettingsObjectWrapper.cpp by functions?

Lubomir I. Ivanov neolit123 at gmail.com
Sat Nov 18 11:25:37 PST 2017


On 18 November 2017 at 21:21, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> On 18 November 2017 at 21:17, Berthold Stoeger
> <bstoeger at mail.tuwien.ac.at> wrote:
>> OK, prepared such a PR.
>>
>
> as noted at the PR comments. could you run your build with `-Wall` to
> see if these changes don't introduce a lot of (char *) <-> (const char
> *) cast warnings?
>

yep, as predicted (but errors for the case of "void *"):

https://travis-ci.org/Subsurface-divelog/subsurface/jobs/304060554
"error: invalid conversion from 'const void*' to 'void*' "

lubomir
--


More information about the subsurface mailing list