Suspicious if/else constructs

Lubomir I. Ivanov neolit123 at gmail.com
Sat Nov 18 13:22:35 PST 2017


On 18 November 2017 at 23:05, Stefan Fuchs <sfuchs at gmx.de> wrote:
> Hallo Berthold,
>
> Am 18.11.2017 um 21:50 schrieb Berthold Stoeger:
>
> In qt-models/diveplannermodel.cpp:341, the if is indented as if it was part
> of
> the outer if. But it isn't owing to missing braces. Since I don't know the
> meaning of "value", I can't decide in this case...
>
> Ups, that is a mistake introduced by me - thanks for catching it!
> Correct would be to unindent line 340-342.
>
> Fell free to correct this otherwise I also can do it (tomorrow)...
>

Berthold, please add a commit to this PR instead of creating a new one:
https://github.com/Subsurface-divelog/subsurface/pull/836

thanks
lubomir
--


More information about the subsurface mailing list