Segfault caused by "Hook qt model for country"

[Lubomir I. Ivanov]

On 4 October 2017 at 01:46, Gaetan Bisson <bisson at archlinux.org> wrote:
> [2017-10-03 12:36:11 -1000] Gaetan Bisson:
>> [2017-10-03 10:56:48 -0700] Dirk Hohndel:
>> > On Mon, Oct 02, 2017 at 04:50:27PM -1000, Gaetan Bisson wrote:
>> > > Hi,
>> > >
>> > > I'm building the latest git snapshot of Subsurface on Arch Linux (we've
>> > > got qt-5.9.1) and the latest commit "Hook qt model for country"
>> > > (d5ab03ef4e84820f9530152dbf4ffc29dec6e652) causes a segfault.
>> > >
>> > > Building goes well but then when running the binary I get:
>> > >
>> > >   Thread 1 "subsurface" received signal SIGSEGV, Segmentation fault.
>> > >   0x0000555555721d87 in DiveListView::DiveListView(QWidget*) ()
>> > >   (gdb) bt
>> > >   #0  0x0000555555721d87 in DiveListView::DiveListView(QWidget*) ()
>> > >   #1  0x000055555566f07e in MainWindow::MainWindow() ()
>> > >   #2  0x000055555566858d in init_ui() ()
>> > >   #3  0x0000555555666f9d in main ()
>> > >
>> > > I've bisected this segfault to that precise commit. I have no idea how
>> > > to debug this further but will be happy to help in any way I can.
>> >
>> > Can you look at the disassembly at the crash and see if this might be
>> > similar to what Lubomir just reported? The loop going way further than it
>> > should?
>>
>> Yes. I've got no segfault after applying Lubomir's pull request.
>
> Though now, if the dive list is nonempty, the dive list widget shows
> *only* the location column.
>

that's odd,
it doesn't happen for me.

i made the default columns widths exactly the same as before.
can you provide a screenshot and also what happens if you resize the
columns to some normal widths and then restart subsurface?

lubomir
--