Defining new dive site using the map

[Lubomir I. Ivanov]

On 15 October 2017 at 22:42, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> On 15 October 2017 at 22:30, Willem Ferguson
> <willemferguson at zoology.up.ac.za> wrote:
>> On 15/10/2017 20:39, Lubomir I. Ivanov wrote:
>>>
>>>
>>> pull-request with a fix created here:
>>> https://github.com/Subsurface-divelog/subsurface/pull/668
>>>
>>> please test, so that we can include this in the next version.
>>>
>>>
>> Lubomir,
>>
>> Works ok on my Ubuntu 16.04 with qt5.5.1, thanks! I can drag the marker now.
>> I had a small glitch at first, but it looks ok, I think I was dragging the
>> marker too rapidly.
>>
>
> thanks for testing.
>
>> A suggestion. Change the colour if the non-finalised marker from red to any
>> colour that contrasts with the rest of the existing markers. Once "Save
>> changes" has been selected, then change the colour back to red???.
>>
>>
>
> both you and Dietrich seem to have good ideas about this.
>
> removing the red might turn the dive-flag into an xxxxx-flag (i.e. a
> flag with a different meaning), so i decided not to do that back when
> i've added the new flag assets.
> visually, it is a very good option though, i must admit.
>
> so, how should the selected marker look if it's not red? what is a
> safe to use color?
>
> ATM we have two makers PNG assets:
> - selected marker (also used when editing) - it's slightly brighter
> - de-selected marker - slightly darker
>
> ideas are welcome.
>

here are the assets in question:

selected:
https://github.com/Subsurface-divelog/subsurface/blob/master/mobile-widgets/qml/icons/mapwidget-marker-selected.png

de-selected:
https://github.com/Subsurface-divelog/subsurface/blob/master/mobile-widgets/qml/icons/mapwidget-marker.png

lubomir
--