Return gas mix from model

Linus Torvalds torvalds at linux-foundation.org
Tue Oct 17 13:11:44 PDT 2017


On Tue, Oct 17, 2017 at 3:01 PM, Robert Helling <helling at atdotde.de> wrote:
>
> So in struct plot_data I added a struct gasmix member

Please don't.

It's easily computable as you traverse the plot info:

            struct gasmix *gasmix = NULL;
            struct event *ev = NULL;

            loop over samples or plot events in increasing time order: {
                    ...
                    gasmix = get_gasmix(dive, dc, time, &ev, gasmix);
                    ...
            }

and our plot info is already unnecessarily big. Let's not add another
redundant element to it.

               Linus


More information about the subsurface mailing list