Import data from Scubapro Aladin Sport Matrix
Berthold Stoeger
bstoeger at mail.tuwien.ac.at
Mon Oct 23 15:38:33 PDT 2017
On Montag, 16. Oktober 2017 08:06:55 CEST Berthold Stoeger wrote:
> Dear all,
>
> On Sonntag, 15. Oktober 2017 22:08:52 CEST Berthold Stoeger wrote:
> > By the way, there seems to be a strange bug(?): for the first failed
> > download I get an information window. For each subsequent retry there is
> > an
> > additional window. E.g. for the 5th failed download it opens 5 information
> > windows at once.
>
> Answering to myself here: The issue seems to be the
> connect(&thread, SIGNAL(finished()), ...);
> call in on_downloadCancelRetryButton_clicked(), which apparently is
> accumulative. Moving this call to the constructor solves the "problem".
> That being said, I don't understand anything of that Qt SIGNAL/SLOT
> business. Moreover, there is a second connect call, which perhaps should
> also be called only once.
Related minor issue: by not clearing the error string of the thread a
successful download after a failed download would still show an error message.
Trivial patch attached. Not exactly sure where to put the error.clear()
though.
Berthold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Clear-error-string-when-starting-dive-computer-downl.patch
Type: text/x-patch
Size: 1007 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20171024/59f3ceda/attachment.bin>
More information about the subsurface
mailing list