[PATCH] Make the map widget more pleasant to use

[Guillaume Gardet]

Hi,


Le 23/10/2017 à 16:26, Linus Torvalds a écrit :
> From: Linus Torvalds <torvalds at linux-foundation.org>
> Date: Mon, 23 Oct 2017 10:04:33 -0400
> Subject: [PATCH] Make the map widget more pleasant to use
>
> This does two main things to the map widget:
>
>   - if there are no coordinates, do *not* zoom out to the whole-world
>     view. Just leave the map alone.
>
>   - when zooming out to move to a new dive site, zoom back in to the same
>     zoom level it was before.
>
> These two changes make it much more pleasant to move between dives,
> particularly as you move back-and-forth without losing the zoom level.
>
> NOTE! The zoom level gets reset if you move dives _while_ zooming is
> happening, and so moving quickly between dives will still end up losing
> the original zoom level, replacing it with a bigger zoom-out that was
> active _during_ a previous zoom.
>
> That could be seen as a feature (moving incrementally to an "overview"
> zoom when moving quickly between dive sites), but honestly it smells
> more like a bug to me.  But regardless of that feature/bug, this new
> zoom behavior is more pleasant than our older "always reset when
> moving".
>
> But it might be a matter of taste, so people should try this out and
> comment.

Just 2 comments.

On startup, the map is not centered as before when no dive location is selected. See the 2 screenshots in attachments. Now, you see the Greenland but not the south America / south Africa.
I prefer the old behavior here.

More annoying, the default zoom level on start-up (for a dive with location info) is too far. You see nearly all the world but as you are very far, you cannot see your dive location. The map is just centered on the dive location.
I think a better default zoom level on start-up would be nice. Maybe with a value in Preferences menu if people want to change it?

For now, I prefer the old behavior.


Guillaume

-------------- next part --------------
A non-text attachment was scrubbed...
Name: new.png
Type: image/png
Size: 259680 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20171024/3567df26/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: old.png
Type: image/png
Size: 246489 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20171024/3567df26/attachment-0003.png>