Thread related crash on failed dive computer download

[Jan Mulder]

Berthold,

On 31-10-17 11:53, Berthold Stoeger wrote:
> Dear all,
> 
> I tried to reset my git repository to head and now I'm getting a crash which I
> didn't get before. I tried "git clean -fx", but that didn't help.
> 
> The crash happens when using invalid Bluetooth addresses. Call trace:
> - core/qt-ble.c l.326: report_error(...)
> - core/errorhelper.c l.43: error_cb()
> - desktop-widgets/mainwindow.cpp l.93: showNotification(...)
> 
> This call doesn't return but produces the following output:
> 
> 
> The crash probably has nothing to do with the membuffer code (which itself
> looks scarily thread-unsafe):
> Replacing l. 93 of desktop-widgets/mainwindow.cpp by
>    mainwindow->getNotificationWidget()->showNotification("test",...);
> still produces the crash. But
>    mainwindow->getNotificationWidget()->showNotification("",...);
> does not crash.
> 
> I have a feeling that I'm doing something obviously wrong, but I don't see it.
> Thank you,

Don't worry. It is not your build environment as I can easily reproduce 
your crash. BLE with incorrect MAC address.

But Dirk has to worry, as it suspiciously close to the new error 
handling code that has just landed in master.

--jan