[PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

[Stefan Fuchs]

Hi Linus,


Am 14.09.2017 um 21:20 schrieb Linus Torvalds:
> From: Linus Torvalds <torvalds at linux-foundation.org>
> Date: Thu, 14 Sep 2017 12:14:33 -0700
> Subject: [PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries
>
> We only cleared the first sensor data when we created new synthetic plot
> info entries, because we only used to have one (well, we had the o2
> data, but apparently nobody ever noticed that it didn't get properly
> interpolated, probably because people who have CCR dives with o2
> pressures are few, and the pressure drops are gradual anyway).
>
> Clear all the pressure data, so that the interpolation code doesn't
> think we have some existing real sensor data for the plot info entries
> in between proper sample entries.
>
> Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
> ---
>
> This fixes the very odd "sometimes interpolation doesn't work". 
Sorry for the maybe stupid questions: This does already solve the issue
with the spike I reported, isn't it?

I first was thinking no, this now is only taking care about s.th.
additional you discovered during your investigations.
But after reading everything again and testing the patch I now believe
this is already the final fix?!

What is clear is that the fix only helps for any newly planned dives
after applying the fix. Any old dive from the planner with the specific
setup will still show the spike because there is the "incorrect"
pressure info in the XML. To fix old dives I need to remove the pressure
info manually in the XML.

Please correct me if I'm wrong!
Thanks!

Best regards
Stefan


-- 

Stefan Fuchs
E-Mail: sfuchs at gmx.de <mailto:sfuchs at gmx.de>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170915/2b93fc6d/attachment-0001.html>