[PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

Linus Torvalds torvalds at linux-foundation.org
Fri Sep 15 11:22:50 PDT 2017


On Fri, Sep 15, 2017 at 5:31 AM, Stefan Fuchs <sfuchs at gmx.de> wrote:
>
> Sorry for the maybe stupid questions: This does already solve the issue with
> the spike I reported, isn't it?

Maybe. I'm not convinced it didn't exist before, though, although
maybe hidden. It definitely existed as far as the o2pressure was
concerned, since that wasn't cleared before either.

> What is clear is that the fix only helps for any newly planned dives after
> applying the fix.

Hmm. Does the planner read back the sample from the plot-info to read
the interpolated values to fill in the samples? I don't think it does,
so it *shoulnd't* be affected by the bug except possibly as it shows
it.

Or maybe it does fill in the planned dive samples with the intepolated
pressures from the plot into, and I'm just not seeing where it does
it. In that case, then yes, the bug would affect a few interpolated
pressure points, and then feed back into the samples that the planner
creates for the planned dive.

                 Linus


More information about the subsurface mailing list