[PATCH 2/2] Properly clear sensor pressure data for synthetic plotinfo entries

[Stefan Fuchs]

Hi Linus, hallo Robert,

sorry, me again regarding the wrong pressure data graph or let's better
say wrong pressure data entry in the XML file where Linus did a pretty
extensive analysis.

Am 15.09.2017 um 20:22 schrieb Linus Torvalds:
> On Fri, Sep 15, 2017 at 5:31 AM, Stefan Fuchs <sfuchs at gmx.de> wrote:
>> Sorry for the maybe stupid questions: This does already solve the issue with
>> the spike I reported, isn't it?
> Maybe. I'm not convinced it didn't exist before, though, although
> maybe hidden. It definitely existed as far as the o2pressure was
> concerned, since that wasn't cleared before either.
I can still create one interesting situation where I finally will have
the issue (all related files are attached):
- I plan a new dive of the specific kind (deco gas used as first gas and
then used later again) with the planner and save it to a new XML file
  --> Everything ok, no vertical line in graph, in XML at time of gas
change 43:35 there is no pressure value. This is as Linus said it should be.
- I close Subsurface, restart, open XML
  --> Everything ok, no vertical line in graph
- Replan dive in planner
  --> Vertical line at ~43min appears and if I now save this and look in
the XML a pressure value was added at 43:35 which is incorrect.

The question is now: Why does the planner (or whatever) does the thing
correctly when creating the dive but then does a mistake when replanning
the same dive?


Best regards
Stefan

-- 

Stefan Fuchs
E-Mail: sfuchs at gmx.de <mailto:sfuchs at gmx.de>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20170920/cae5356a/attachment-0001.html>
-------------- next part --------------
<divelog program='subsurface' version='3'>
<settings>
</settings>
<divesites>
</divesites>
<dives>
<dive number='1' date='2017-09-20' time='10:49:57' duration='75:16 min'>
  <notes><div><b>Subsurface (4.6.4.842) Plan</b> erstellt am 20.09.17</b><br>Runtime: 75min<br></div><table><thead><tr><th></th><th>Tiefe</th><th style='padding-left: 10px;'>Dauer</th><th style='padding-left: 10px;'>Runtime</th><th style='padding-left: 10px; float: left;'>Gas</th></tr></thead><tbody style='float: left;'><tr><td style='padding-left: 10px; float: right;'>&#10136;</td><td style='padding-left: 10px; float: right;'> 15m</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; color: red; float: left;'><b>EAN50</b></td></tr><tr><td style='padding-left: 10px; float: right;'>&#10137;</td><td style='padding-left: 10px; float: right;'> 15m</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; float: right;'> 10min</td><td style='padding-left: 10px; color: red; float: left;'><b>(21/35)</b></td></tr><tr><td style='padding-left: 10px; float: right;'>&#10136;</td><td style='padding-left: 10px; float: right;'> 45m</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; float: right;'> 15min</td><td>&nbsp;</td></tr><tr><td style='padding-left: 10px; float: right;'>&#10137;</td><td style='padding-left: 10px; float: right;'> 45m</td><td style='padding-left: 10px; float: right;'> 25min</td><td style='padding-left: 10px; float: right;'> 40min</td><td>&nbsp;</td></tr><tr><td style='padding-left: 10px; float: right;'>&#10138;</td><td style='padding-left: 10px; float: right;'> 21m</td><td style='padding-left: 10px; float: right;'>  4min</td><td style='padding-left: 10px; float: right;'> 44min</td><td>&nbsp;</td></tr><tr><td style='padding-left: 10px; float: right;'>-</td><td style='padding-left: 10px; float: right;'> 21m</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; float: right;'> 49min</td><td style='padding-left: 10px; color: red; float: left;'><b>EAN50</b></td></tr><tr><td style='padding-left: 10px; float: right;'>-</td><td style='padding-left: 10px; float: right;'>  9m</td><td style='padding-left: 10px; float: right;'>  6min</td><td style='padding-left: 10px; float: right;'> 55min</td><td>&nbsp;</td></tr><tr><td style='padding-left: 10px; float: right;'>-</td><td style='padding-left: 10px; float: right;'>  6m</td><td style='padding-left: 10px; float: right;'> 14min</td><td style='padding-left: 10px; float: right;'> 69min</td><td style='padding-left: 10px; color: red; float: left;'><b>Sauerstoff</b></td></tr><tr><td style='padding-left: 10px; float: right;'>&#10138;</td><td style='padding-left: 10px; float: right;'>  0m</td><td style='padding-left: 10px; float: right;'>  6min</td><td style='padding-left: 10px; float: right;'> 75min</td><td>&nbsp;</td></tr></tbody></table><br><div>CNS: 65%<br>OTU: 112<br></div><div>Dekomodell: VPM-B mit Konservatismus +2, effektive GF=75/75<br>Oberflächendruck: 1013mbar (0m)<br></div><div>Gasverbrauch (basierend auf AMV 18|15ℓ/min):<br>854ℓ/77bar von <span style='color: red;'><b>EAN50</b></span> (474ℓ/44bar im berechneten Aufstieg)<br>3017ℓ/131bar von <span style='color: red;'><b>(21/35)</b></span> (211ℓ/9bar im berechneten Aufstieg)<br>&nbsp;&mdash; <span style='color: red;'>Minimum gas</span> (based on 3.3xSAC/+4min at 45m): 2008ℓ/84bar<br>432ℓ/59bar von <span style='color: red;'><b>Sauerstoff</b></span> (432ℓ/61bar im berechneten Aufstieg)<br></div></notes>
  <cylinder size='11.094 l' workpressure='210.0 bar' description='AL80' o2='50.0%' start='210.0 bar' end='133.112 bar' />
  <cylinder size='24.0 l' workpressure='200.0 bar' description='D12 232 bar' o2='21.0%' he='35.0%' start='200.0 bar' end='69.31 bar' />
  <cylinder size='7.0 l' workpressure='200.0 bar' description='ALU7' o2='100.0%' start='200.0 bar' end='141.048 bar' />
  <divecomputer model='planned dive'>
  <depth max='45.0 m' mean='23.717 m' />
  <surface pressure='1.013 bar' />
  <water salinity='1020 g/l' />
  <event time='10:01 min' type='25' value='2293781' name='gaschange' cylinder='1' o2='21.0%' he='35.0%' />
  <event time='43:35 min' type='11' value='50' name='gaschange' cylinder='0' o2='50.0%' />
  <event time='56:01 min' type='11' value='100' name='gaschange' cylinder='2' o2='100.0%' />
  <sample time='0:00 min' depth='0.0 m' pressure='210.0 bar' />
  <sample time='5:00 min' depth='15.0 m' pressure='195.716 bar' />
  <sample time='10:00 min' depth='15.0 m' pressure='175.484 bar' />
  <sample time='10:01 min' depth='15.0 m' />
  <sample time='15:00 min' depth='45.0 m' pressure='184.461 bar' />
  <sample time='40:00 min' depth='45.0 m' pressure='78.159 bar' />
  <sample time='41:54 min' depth='25.998 m' pressure='72.782 bar' />
  <sample time='43:34 min' depth='21.0 m' pressure='69.31 bar' />
  <sample time='43:35 min' depth='21.0 m' pressure='157.6 bar' />
  <sample time='48:34 min' depth='21.0 m' pressure='154.843 bar' />
  <sample time='52:34 min' depth='9.0 m' pressure='141.559 bar' />
  <sample time='55:00 min' depth='9.0 m' pressure='135.429 bar' />
  <sample time='56:00 min' depth='6.0 m' pressure='133.112 bar' />
  <sample time='56:01 min' depth='6.0 m' />
  <sample time='69:00 min' depth='6.0 m' pressure='157.6 bar' />
  <sample time='75:16 min' depth='0.0 m' pressure='141.048 bar' />
  </divecomputer>
</dive>
</dives>
</divelog>
-------------- next part --------------
<divelog program='subsurface' version='3'>
<settings>
</settings>
<divesites>
</divesites>
<dives>
<dive number='1' date='2017-09-20' time='10:49:57' duration='75:16 min'>
  <notes><div><b>Subsurface (4.6.4.842) Plan</b> erstellt am 20.09.17</b><br>Runtime: 75min<br></div><table><thead><tr><th></th><th>Tiefe</th><th style='padding-left: 10px;'>Dauer</th><th style='padding-left: 10px;'>Runtime</th><th style='padding-left: 10px; float: left;'>Gas</th></tr></thead><tbody style='float: left;'><tr><td style='padding-left: 10px; float: right;'>&#10136;</td><td style='padding-left: 10px; float: right;'> 15m</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; color: red; float: left;'><b>EAN50</b></td></tr><tr><td style='padding-left: 10px; float: right;'>&#10137;</td><td style='padding-left: 10px; float: right;'> 15m</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; float: right;'> 10min</td><td style='padding-left: 10px; color: red; float: left;'><b>(21/35)</b></td></tr><tr><td style='padding-left: 10px; float: right;'>&#10136;</td><td style='padding-left: 10px; float: right;'> 45m</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; float: right;'> 15min</td><td>&nbsp;</td></tr><tr><td style='padding-left: 10px; float: right;'>&#10137;</td><td style='padding-left: 10px; float: right;'> 45m</td><td style='padding-left: 10px; float: right;'> 25min</td><td style='padding-left: 10px; float: right;'> 40min</td><td>&nbsp;</td></tr><tr><td style='padding-left: 10px; float: right;'>&#10138;</td><td style='padding-left: 10px; float: right;'> 21m</td><td style='padding-left: 10px; float: right;'>  4min</td><td style='padding-left: 10px; float: right;'> 44min</td><td>&nbsp;</td></tr><tr><td style='padding-left: 10px; float: right;'>-</td><td style='padding-left: 10px; float: right;'> 21m</td><td style='padding-left: 10px; float: right;'>  5min</td><td style='padding-left: 10px; float: right;'> 49min</td><td style='padding-left: 10px; color: red; float: left;'><b>EAN50</b></td></tr><tr><td style='padding-left: 10px; float: right;'>-</td><td style='padding-left: 10px; float: right;'>  9m</td><td style='padding-left: 10px; float: right;'>  6min</td><td style='padding-left: 10px; float: right;'> 55min</td><td>&nbsp;</td></tr><tr><td style='padding-left: 10px; float: right;'>-</td><td style='padding-left: 10px; float: right;'>  6m</td><td style='padding-left: 10px; float: right;'> 14min</td><td style='padding-left: 10px; float: right;'> 69min</td><td style='padding-left: 10px; color: red; float: left;'><b>Sauerstoff</b></td></tr><tr><td style='padding-left: 10px; float: right;'>&#10138;</td><td style='padding-left: 10px; float: right;'>  0m</td><td style='padding-left: 10px; float: right;'>  6min</td><td style='padding-left: 10px; float: right;'> 75min</td><td>&nbsp;</td></tr></tbody></table><br><div>CNS: 65%<br>OTU: 112<br></div><div>Dekomodell: VPM-B mit Konservatismus +2, effektive GF=75/75<br>Oberflächendruck: 1013mbar (0m)<br></div><div>Gasverbrauch (basierend auf AMV 18|15ℓ/min):<br>854ℓ/77bar von <span style='color: red;'><b>EAN50</b></span> (474ℓ/44bar im berechneten Aufstieg)<br>3017ℓ/131bar von <span style='color: red;'><b>(21/35)</b></span> (211ℓ/9bar im berechneten Aufstieg)<br>&nbsp;&mdash; <span style='color: red;'>Minimum gas</span> (based on 3.3xSAC/+4min at 45m): 2008ℓ/84bar<br>432ℓ/59bar von <span style='color: red;'><b>Sauerstoff</b></span> (432ℓ/61bar im berechneten Aufstieg)<br></div></notes>
  <cylinder size='11.094 l' workpressure='210.0 bar' description='AL80' o2='50.0%' start='210.0 bar' end='133.112 bar' />
  <cylinder size='24.0 l' workpressure='200.0 bar' description='D12 232 bar' o2='21.0%' he='35.0%' start='200.0 bar' end='69.31 bar' />
  <cylinder size='7.0 l' workpressure='200.0 bar' description='ALU7' o2='100.0%' start='200.0 bar' end='141.048 bar' />
  <divecomputer model='planned dive'>
  <depth max='45.0 m' mean='23.717 m' />
  <surface pressure='1.013 bar' />
  <water salinity='1020 g/l' />
  <event time='10:01 min' type='25' value='2293781' name='gaschange' cylinder='1' o2='21.0%' he='35.0%' />
  <event time='43:35 min' type='11' value='50' name='gaschange' cylinder='0' o2='50.0%' />
  <event time='56:01 min' type='11' value='100' name='gaschange' cylinder='2' o2='100.0%' />
  <sample time='0:00 min' depth='0.0 m' pressure='210.0 bar' />
  <sample time='5:00 min' depth='15.0 m' pressure='195.716 bar' />
  <sample time='10:00 min' depth='15.0 m' pressure='175.484 bar' />
  <sample time='10:01 min' depth='15.0 m' />
  <sample time='15:00 min' depth='45.0 m' pressure='184.461 bar' />
  <sample time='40:00 min' depth='45.0 m' pressure='78.159 bar' />
  <sample time='41:54 min' depth='25.998 m' pressure='72.782 bar' />
  <sample time='43:34 min' depth='21.0 m' pressure='69.31 bar' />
  <sample time='43:35 min' depth='21.0 m' />
  <sample time='48:34 min' depth='21.0 m' pressure='154.843 bar' />
  <sample time='52:34 min' depth='9.0 m' pressure='141.559 bar' />
  <sample time='55:00 min' depth='9.0 m' pressure='135.429 bar' />
  <sample time='56:00 min' depth='6.0 m' pressure='133.112 bar' />
  <sample time='56:01 min' depth='6.0 m' />
  <sample time='69:00 min' depth='6.0 m' pressure='157.6 bar' />
  <sample time='75:16 min' depth='0.0 m' pressure='141.048 bar' />
  </divecomputer>
</dive>
</dives>
</divelog>