Any brave dive computer download testers out there?

Dirk Hohndel dirk at hohndel.org
Wed Apr 18 11:48:38 PDT 2018


> On Apr 18, 2018, at 8:40 PM, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> 
>> - Successful download over BLE
>> - Cannot download over classic BT (it always goes to BLE, even in case
>> "force classic" in the UI is chosen). But unsure this is related to the
>> transport refactoring.
> 
> Yeah, right now the logic is "if we support BLE, and the dive computer
> supports BLE, then we'll use BLE".
> 
> We'll fall back to rfcomm only when libdivecomputer says that the
> divecomputer only does legacy BT.

I think that's backwards. If the dive computer and the Subsurface version
both support BT, we should prefer that over BLE by default.

> I realize that we have that "force BT/BLE" thing, but it sadly doesn't
> actually set the "bluetooth_mode". That's a boolean, and is true for
> both BT and BLE.
> 
> I think it does change the "devname", and I guess I could test that.

Yes, it uses the LE: prefix. And it might still make sense to keep this
but we really should prefer BT over BLE simply for speed reasons

/D


More information about the subsurface mailing list