Cleaned up and rebased "libdivecomputer-NG" branch

[Dirk Hohndel]

On Wed, Apr 25, 2018 at 01:04:36PM -0700, Linus Torvalds wrote:
> On Wed, Apr 25, 2018 at 12:57 PM, Linus Torvalds
> <torvalds at linux-foundation.org> wrote:
> >
> > Odd. It was _supposed_ to apply to current master.
> 
> Ok, apparently you worked it out.

Yes

> Anyway, the commit message could be something simple along the lines of
> 
>     Do a better job of picking which transport to use
> 
>     If the user specified bluetooth, we really should pick bluetooth, not
>     probe and possibly fall back to something else.
> 
>     We should also honor the users choice of BLE vs classic BT.
> 
>     Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>

I'll add that.


> or similar. But it _would_ be good to test that this actually makes
> Petrel 2 work with rfcomm. Because it's certainly possible that there
> is something else wrong with rfcomm.

Right now I'm testing.

(1) BT-only Petrel and Android: works
    - but if you cancel on the Petrel (which makes it shut down its BT
      stack) then Subsurface-mobile gets confused. It keeps sitting in the
      download screen, Cancel doesn't work, and I can't get it to show me
      the dives that it has downloaded so far.
(2) dual stack Petrel 2 and Android:
    - RF Connect claims this is an LE only device
    - whatever I try, it refuses to pair / connect / bond
    I know that this Petrel 2 has connected to this Android phone before,
    so this is yet another of these "what the heck is going on" situations.
    Next I'll remove the battery and reboot the phone, but I'm running out
    of ideas how to make this work.

I ran out of time testing on Mac.

> Maybe we have screwed up the rfcomm channel number logic or something?
> Because we have a very special case with that whole "channel number
> 5". That's all old code and I had nothing to do with it (because I've
> never had anything that worked with this anyway).

If I had any faith that the Petrel 2 wasn't completely hosed, I'd bring it
over to you...

/D