[PATCH] Reverse html trip list rendering order

Dirk Hohndel dirk at hohndel.org
Mon Aug 13 10:01:18 PDT 2018


BTW, I applied this on the server as well so that the logs shown at https://cloud.subsurface-divelog.org will also show trips in the logical order.
BUT: your browser is likely to cache the list_lib.js file, so you may have to clear the cache in order to see the effect

/D

> On Aug 13, 2018, at 8:28 AM, Monty Taylor <mordred at inaugust.com> wrote:
> 
> In the HTML export, the list of trips emitted into lib.js is in
> chronological order, the dives are shown reverse chronological order.
> This leads to a weird experience of the earliest trip being on top and
> the dives within it having the most recent dive on top.
> 
> Invert the processing order in the javascript layer so that the last
> trip is rendered first.
> 
> Signed-off-by: Monty Taylor <mordred at inaugust.com>
> ---
> theme/list_lib.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/theme/list_lib.js b/theme/list_lib.js
> index 34e4a6043..409229a91 100644
> --- a/theme/list_lib.js
> +++ b/theme/list_lib.js
> @@ -772,7 +772,7 @@ function showtrips()
> {
> 	var divelist = document.getElementById('diveslist');
> 	divelist.innerHTML = "";
> -	for (var i = 0; i < trips.length; i++) {
> +	for (var i = trips.length - 1; i >= 0; i--) {
> 		divelist.innerHTML += '<ul id="trip_' + i + '" class="trips" onclick="toggle_trip_expansion(' + i + ')">' +
> 				      trips[i].name + ' ( ' + trips[i].dives.length + ' dives)' + '</ul>' + '<div id="trip_dive_list_' + i + '"></div>';
> 	};
> -- 
> 2.17.1
> 
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface



More information about the subsurface mailing list