Support for Gamrin Descent MK1
Linus Torvalds
torvalds at linux-foundation.org
Wed Aug 29 19:54:18 PDT 2018
On Wed, Aug 29, 2018 at 7:06 PM Wojciech Więckowski <xplwowi at gmail.com> wrote:
>
> Wow - I'm impressed. I just strarted testing dctool compiled from your branch.
Ahh. I haven't used dctool in a long while. It's of dubious use, but I
guess for testing it's fine, and it's easier to build than subsurface
is.
> In comment for commit modifying common.c I informed you that:
Ok, you seem to have done it on the github comment system, so I missed it.
I don't actually use github that way - I have all notifications turned
off, because they are way too noisy for me. So I basically use github
as a hosting place, without ever looking at the other things github
offers.
And yeah, I have no idea how src/libdivecomputer.symbols is supposed
to work, I think it's some odd Windows thing, so I missed it entirely.
Is that the only symbol that needs adding?
> I'm reading your commits messages and observing code changes.
I'm done for a while. It's not perfect, but it is "good enough" for
me, and I'm traveling a bit the rest of the week.
So I might get back to it to finish up some odds and ends on the
weekend, but for now it is what it is. Comments welcome, but it's
probably best to just email me directly than to use the github comment
system. Or comment on github, but send me an email telling me to go
look.
> There are a lot of GPS coordinates stored in LAP records but I see no
> reason to support them as whole dive summary is stored in SESSION
> record. Laps are created after surfacing, spending there less than 1
> minute (time can be defined) and immersing again. Laps don't affect
> sample timers, what is obvious as they are related to Garmin's epoch.
As you'll find out, I wrote the parser basically by just looking at
what fields I could find in your and Dirk's FIT files, and then
looking at patterns.
I didn't even filter by activity, which is why it currently happily
creates a "dive" even from non-dive activity. It won't have any actual
*dive* data, but it can have random other data - like GPS points.
So there's definitely a fair amount of "cleanup and polishing" for
this to be a *good* Garmin downloader, but it seems to mostly work
already.
I'll be diving for a few days in a week or two, and then I'll actually
get to test the Garmin Descent myself. Right now I've just been
working off other peoples data.
Linus
More information about the subsurface
mailing list