Missing pO2 samples from CCR download [was: 4.7.8: a couple of questions]

[Anton Lundin]

Here's the patches.

I splitted them into two, so Jef can cherry-pick the first one, and a
second one which adds a strings that says the source of the PPO2 values.


//Anton


On 18 June, 2018 - Dirk Hohndel wrote:

> As I said before, I can't seem to find that patch. No idea why. If someone sends it to me I'll be happy to add it. I said that before as well.
> If hate to see Davide abandon Subsurface over this...
> 
> /D
> 
> On June 18, 2018 5:39:43 AM GMT+09:00, "Long, Martin" <martin at longhome.co.uk> wrote:
> >Dirk,
> >
> >I would say that Anton's patch would do it as an interim solution. Jef
> >isn't keen, as he has a better solution, but doesn't have the time to
> >work
> >on it yet. However, it does remove the regression, and prevent further
> >loss
> >of data in imports, until the *ideal* solution can be added. Data is
> >still
> >being lost, which is frustrating - I can't seem my actual ppO2 from
> >dives I
> >did yesterday, and now I never will, for those dives.
> >
> >Rather take an imperfect patch, which works now, than leave it broken
> >waiting for the perfect one (and no idea of how long it will take).
> >
> >On 17 June 2018 at 12:02, Dirk Hohndel <dirk at hohndel.org> wrote:
> >
> >>
> >> On Jun 17, 2018, at 6:52 PM, Davide DB <dbdavide at gmail.com> wrote:
> >>
> >> On Thu, Jun 14, 2018, 15:34 Long, Martin <martin at longhome.co.uk>
> >wrote:
> >>
> >>> I'm in agreement with Davide that any interim solution we can get
> >running
> >>> is better than the way it is working now. It's a regression, and tbh
> >if
> >>> there isn't an interim solution then it ought to be reverted to the
> >old
> >>> behaviour. At the moment I'm having to use Shearwater desktop for
> >reviewing
> >>> all my logs.
> >>>
> >>
> >> I had to stop using Subsurface for the time being. First time in so
> >many
> >> years.
> >>
> >> If the bug will be solved I would have to transfer and compile from
> >> scratch more than 60 dives (until now). I don't know if I will have
> >the
> >> time or will to do all this work and frankly speaking I'm tired to be
> >> always a minority.
> >>
> >> Farewell my friends. It has been a nice journey. Thank you all for
> >the
> >> amazing work.
> >>
> >>>
> >> Sorry to see you leave and thank you for all the great contributions.
> >> Subsurface-mobile wouldn't be anywhere near where it is today if it
> >wasn't
> >> for you.
> >>
> >> I'll admit that I completely tune out rebreather discussions - I
> >assume
> >> that those who care about rebreathers will figure things out and will
> >send
> >> me pull requests.
> >>
> >> Since I'd hate to see you go, is there actually something that we can
> >do
> >> to fix this? Or are we (as in so many small odd corner cases) at a
> >point
> >> where we just don't have the right person to work on something (like
> >the
> >> FTDI download on Android)?
> >>
> >> /D
> >>
> >>
> 
> -- 
> from my phone.

> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


-- 
Anton Lundin	+46702-161604
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-shearwater-Fallback-to-average-voted-ppo2.patch
Type: text/x-diff
Size: 2223 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180620/55ae091e/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-shearwater-Emit-a-string-saying-the-source-of-ppo2-v.patch
Type: text/x-diff
Size: 1057 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180620/55ae091e/attachment-0003.patch>