Product / vendor on mobile download

[Thomas Fänge]

Hi Linus,

Yes, you are right, failure in dc_serial_open drops down to ftdi_open.

>> But you cut out the rest of the output..

No, that all there was in the libdivecomputer.log, after that error the log
was empty (and proceeding this is only version information), so the INFO
and ERROR line is the complete log.

    ---------- libdivecomputer.log ----------
    Subsurface: v4.7.8-287-g76f61468e690, built with libdivecomputer
v0.7.0-devel-Subsurface-NG (e97a47cca55973199715df0f818b4955e60d3a31)
    INFO: Open: name=ftdi
    ERROR: No such file or directory (2) [in
/data/android/subsurface/libdivecomputer/src/serial_posix.c:295
(dc_serial_open)]
    ---------- finish ----------

Somewhere along these lines, DC_STATUS_UNSUPPORTED is returned which causes
the output "Unsupported operation", don't know if this is pointing
somewhere, or is just also expected information ... ;)

But, I guess Dirk is right, there is still some confusion about using OTG
cable, Bluetooth Link, FTDI etc, so there are still some hurdles to pass ...

Best regards,
Thomas



tors 21 juni 2018 kl 08:53 skrev Linus Torvalds <
torvalds at linux-foundation.org>:

> On Thu, Jun 21, 2018 at 3:17 PM Thomas Fänge <thomas.fange at gmail.com>
> wrote:
> >
> > Still the same error from libdivecomputer:
> >
> >     INFO: Open: name=ftdi
> >     ERROR: No such file or directory (2) [in
> /data/android/subsurface/libdivecomputer/src/serial_posix.c:295
> (dc_serial_open)]
>
> Note: this is "normal".
>
> The DC_TRANSPORT_SERIAL first just calls dc_serial_open(), and only if
> that fails will it then try to fall back on the "ftdi_open()" case.
>
>                 rc = dc_serial_open(&data->iostream, context,
> data->devname);
>                 if (rc == DC_STATUS_SUCCESS)
>                         return rc;
>
>   #ifdef SERIAL_FTDI
>                 if (!strcmp(data->devname, "ftdi")) {
>                         rc = ftdi_open(&data->iostream, context);
>                         if (rc == DC_STATUS_SUCCESS)
>                                 return rc;
>                 }
>   #endif
>
> so an error from dc_serial_open() is actually expected.
>
> I guess we could move the ftdi check up.
>
> If the FTDI open fails, it should print an error message right *after*
> the one from dc_serial_open(). But you cut out the rest of the
> output..
>
>              Linus
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180621/27f1eca8/attachment-0001.html>