Planner: Bug in PR by bstoeger

[Berthold Stoeger]

Hi Willem,

On Freitag, 18. Mai 2018 10:30:28 CEST you wrote:

> On March 14th you introduced a PR entitled Cleanup: fix "unsave"
> snprintf()s in plannernotes.c
> <https://github.com/Subsurface-divelog/subsurface/commit/a4834e198d55d50a44d
> 6f80e2137777b64652ce7#diff-0df10959bbcbe5342528360ce6f541a5> for Subsurface.
> 
> This PR affected the function  add_icd_entry() in plannernotes.c. The
> changes, unfortunately, introduced a bug in the display of the icd data
> for a dive. I include a sample dive plan so that you can see the effect
> of this change in code. Activate the display of icd data in Preferences,
> open the attached dive plan and edit the dive plan within the planner.
> You will see random information being added to the icd data. In fact the
> icd data are quite messed up because the table should include two lines
> of gas change information. At least part of the problem lies in lines
> 55-68 of plannernotes.c.

Unfortunately, I can't reproduce this (don't get an ICD-warning?). But there 
is an obvious bug in the handling of the ICD buffer. Could you try the 
attached patch?

Thank you,

Berthold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Plannernotes-0-terminate-ICD-buffer.patch
Type: text/x-patch
Size: 1196 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20180518/a015a10f/attachment-0001.bin>