Planner: Bug in PR by bstoeger
willemferguson at zoology.up.ac.za
Fri May 18 03:29:11 PDT 2018
On 18/05/2018 11:57, Berthold Stoeger wrote:
> Hi Willem,
> On Freitag, 18. Mai 2018 10:30:28 CEST you wrote:
>> On March 14th you introduced a PR entitled Cleanup: fix "unsave"
>> snprintf()s in plannernotes.c
>> 6f80e2137777b64652ce7#diff-0df10959bbcbe5342528360ce6f541a5> for Subsurface.
>> This PR affected the function add_icd_entry() in plannernotes.c. The
>> changes, unfortunately, introduced a bug in the display of the icd data
>> for a dive. I include a sample dive plan so that you can see the effect
>> of this change in code. Activate the display of icd data in Preferences,
>> open the attached dive plan and edit the dive plan within the planner.
>> You will see random information being added to the icd data. In fact the
>> icd data are quite messed up because the table should include two lines
>> of gas change information. At least part of the problem lies in lines
>> 55-68 of plannernotes.c.
> Unfortunately, I can't reproduce this (don't get an ICD-warning?). But there
> is an obvious bug in the handling of the ICD buffer. Could you try the
> attached patch?
> Thank you,
That does fix it. Will you please do a PR?
This message and attachments are subject to a disclaimer.
Please refer to
More information about the subsurface