Garmin support: ignore FIT files that aren't dives

Dirk Hohndel dirk at hohndel.org
Tue Sep 4 07:38:29 PDT 2018


> On Sep 3, 2018, at 8:31 PM, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> 
> On Mon, Sep 3, 2018 at 2:39 PM Dirk Hohndel <dirk at hohndel.org> wrote:
>> 
>> It bugged me that we kept offering all the other activities for download, so I
>> added a small commit that would make us look at the sub_sport before
>> offering the "dive" to Subsurface...
> 
> Patch looks fine to me. Not optimal, but not wrong.
> 
> Note that doing this right, you should also be able to do do the
> DC_EVENT_DEVINFO event from the downloader (just once), since you'd
> have the firmware/serial info now.

Good idea. Ignore this patch. I'll send a better one that solves this at the
same time.

/D


More information about the subsurface mailing list