Android FTDI support not working with fresh app build

[Dirk Hohndel]

> On Sep 16, 2018, at 8:48 AM, Bill Perry <bperrybap at opensource.billsworld.billandterrie.com> wrote:
> 
> 
> On 09/16/2018 06:52 AM, Anton Lundin wrote:
>> On 14 September, 2018 - Bill Perry wrote:
>> 
>> 
>> Nothing else was changed on the machine other then I started with a clean clone and checked out v4.8.1 vs using the head of Master.
>> This apk worked as expected including having the proper command/message delays
>> whereas the current app from the app store (4.8.1) does not have the proper delays.
>> 
>> I'm at a loss to explain the delay issue, but I can see it on a logic analyzer.
>> Might be anything. My suspect would be powersave on your android device.
> 
> Turns out I'm blind and couldn't read my own notes.
> The playstore app was 4.8.0 not 4.8.1
> The delay issue has been resolved between the 4.8.0 release and the 4.8.1 release.

Darn - I should have updated the playstore app. Well, I'll do this in the next couple of days with 4.8.2/2.1.2

>> ps. I think the conditional return in:
>> #ifdef SERIAL_FTDI
>> 	if (!strcmp(data->devname, "ftdi")) {
>> 		rc = ftdi_open(&data->iostream, context);
>> 		if (rc == DC_STATUS_SUCCESS)
>> 			return rc;
>> 	}
>> #endif
>> 
>> is wrong. If the devname is "ftdi" we should always return, whatever
>> ftdi_open returned.
>> 
> 
> Ah. I overlooked that. That does seem wrong.

Yep, I pulled Anton's fix this morning, that will also be fixed in the upcoming version 2.1.2
of Subsurface-mobile

/D