dive sites, edit undo, and the major steps towards 4.9

Doug Junkins douglas.junkins at gmail.com
Sat Apr 13 09:50:49 PDT 2019


One thing I have been contemplating now that dive sites can be managed independent of dives is that it should be possible to create a dive site on the mobile app (either from the current location or from a saved GPS fix) that can later be used when a dive is imported from a dive computer on a desktop machine. This will mean adding the dive site management and addition code to the mobile app.

Just something to think about as we look at what features should move from the desktop into the mobile app.


> On Apr 13, 2019, at 9:27 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> While I still haven't announced 4.8.6 (I'm on the plane back home - I think I'll announce it later today), I wanted to start the conversation about 4.9.
> We just merged a massive PR from Berthold that brings something that Henrik and others have asked for for a very long time. Dive sites are becoming a first class citizen.
> There's now a dive sites tab (from a UI perspective this isn't perfect - but for now this works reasonably well), thanks to a patch from Doug you can export dive sites, and you can work with the dive site list to manage them on their own, not just in the context of a dive.
> I think it would be great if those of you who have shown strong interest in managing dive sites could play with the latest master and provide feedback and input. We want to make sure that we get this right, both from the point of views of the concepts that we use around dive sites, but also from a UI perspective. 
> The other new thing that's in master (as those two were tightly interconnected in the implementation) is a much more expanded undo functionality when editing dives - which fundamentally changes the work flow when editing dives. Instead of the edit mode (* hold that thought) where you can accept or reject edits of a dive, every single edit (within reason - not every key stroke when editing notes) is an undo event and can be simply undone. And correspondingly, every single edit immediately applies to the dive in the dive list.
> There are a couple of exceptions: tanks, weights, and editing the dive points of a manually added dives by dragging things around in the profile. Those still use the old accept / reject concept (which creates a rather inconsistent user experience right now - but it seemed the right time to merge this massive PR, even with a couple of items missing). This part could use serious testing, feedback and bug reports, and of course updates to the documentation.
> I would like to send a huge THANK YOU to Berthold for his impressive work on this and his tolerance for me asking him a million question, being confused by some of the language constructs used, etc. I think this is a massive improvement of Subsurface on the desktop.
> There are binaries on GitHub, I can also make Mac binaries available if anyone is interested (I think the ones from GitHub still don't always work - I haven't tested the latest app.zip TBH)
> Thanks
> /D
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

More information about the subsurface mailing list