current master is broken with Subsurface-mobile

Dirk Hohndel dirk at hohndel.org
Tue Apr 16 05:16:49 PDT 2019


On Tue, Apr 16, 2019 at 08:55:13AM +0200, Berthold Stoeger wrote:
> On Dienstag, 16. April 2019 02:03:17 CEST Dirk Hohndel wrote:
> > I haven't tried to track this down, just in case someone has some time to
> > try to bisect this:
> > 
> > current master doesn't appear to populate the connection combo box when
> > selecting download in Subsurface-mobile. It finds the dive computers (so
> > it's not the BT/BLE scanning that's broken), but the combo box in the QML
> > UI stays empty
> > 
> > I may have time to play with it later this week, but I'm once again getting
> > on a plane in a little while, so I'm not able to jump on it right now.
> 
> It's the removal of the ConnectionListModel::roleNames() function in
> c69ca4df80c9c74aa842b7f1fb3c44b22ae3232e. Don't ask me why.

How odd. Thanks for tracking this down. I merged your PR and verified that
this works, again.

Thanks

/D


More information about the subsurface mailing list