G2 HUD support?

[William Perry]

With Jef’s changes to libdivecomputer I was able to download over USB just fine.  The bluetooth seems a little iffy - I was able to download after forcing it into LE mode.  It looks like the bluetooth device name starts with ‘HUD’:

diff --git a/core/btdiscovery.cpp b/core/btdiscovery.cpp
index 7e75994da..c057abd8b 100644
--- a/core/btdiscovery.cpp
+++ b/core/btdiscovery.cpp
@@ -56,9 +56,10 @@ static dc_descriptor_t *getDeviceType(QString btName)
 		product = "EON Core";
 	}
 
-	if (btName.startsWith("G2")  || btName.startsWith("Aladin")) {
+	if (btName.startsWith("G2")  || btName.startsWith("Aladin") || btName.startsWith("HUD")) {
 		vendor = "Scubapro";
 		if (btName.startsWith("G2")) product = "G2";
+		if (btName.startsWith("HUD")) product = "G2 HUD";
 		if (btName.startsWith("Aladin")) product = "Aladin Sport Matrix";
 	}
 


-bill

> On Apr 25, 2019, at 8:49 AM, William Perry <wmperry at kadath.us> wrote:
> 
> I have a build of subsurface with your changes in it and will be spending the day at the quarry.  Will see if I can snag the HUD while I am down there.
> 
> -Bill
> 
>> On Apr 24, 2019, at 10:58 AM, Jef Driesen <jef at libdivecomputer.org> wrote:
>> 
>> On 2019-04-23 22:32, Linus Torvalds wrote:
>> 
>>> Have you found where the GPS coordinates might be? The G2 HUD
>>> allegedly supports GPS.
>>> (Btw, right now we export GPS information with the extra-string
>>> interface, but it would actually be much better to have an actual GPS
>>> event. No, they won't happen under water, but in addition to the
>>> beginning/end they can happen in the middle of the dive when
>>> surfacing, so an event with a timestamp etc would be really useful).
>> 
>> No, I didn't look for the GPS info. Since the Uwatec data format uses a type/value encoding for the sample data and I didn't notice a new type, the only place where GPS info can be stored is in the MISC sample. I have seen some unknown subtypes before. A quick check shows there are indeed some unknown subtypes present in the G2 HUD data:
>> 
>> Unknown misc sample with type 24 and length 3.
>> Unknown misc sample with type 16 and length 91.
>> Unknown misc sample with type 17 and length 67.
>> 
>>>> I have the necessary fixes ready to push.
>>> Apparently they aren't out yet, but I'll merge them when they are and
>>> we can get testing going.
>> 
>> I have pushed the changes now.
>> 
>> Jef
>