4.9

Berthold Stoeger bstoeger at mail.tuwien.ac.at
Sun Jul 14 14:16:52 PDT 2019


On Sunday, 14 July 2019 22:53:07 CEST Linus Torvalds wrote:

> Steve's problem with the cylinder usage was easy to reproduce.
> 
> Just export one dive that has a cylinder as xml. Then edit it to add
> something like
> 
>     use="impossible"
> 
> for the cylinder.

Sure, but what I'd like to understand is how you get to that situation during 
normal usage. Note that it was loading from cloud storage that resulted in the 
problem. Perhaps I'm paranoid, but this reeks of memory corruption to me.

While your fix is certainly correct - I wonder if it is hiding a more 
fundamental problem. Whatever it is - you still lose the cylinder-use data. 
Better than a crash for sure, but still not ideal.

Berthold




More information about the subsurface mailing list