Bugs: profile for hand-entered dives

[Dirk Hohndel]

Indeed, that's broken.
I'll take a look

/D

On June 24, 2019 2:02:27 AM GMT+08:00, Patrick Valsecchi <patrick at thus.ch> wrote:
>Hi
>
>I see another problem in this area of the soft. Changing the date is
>not 
>working:
>
>1) Log -> Add dive
>
>2) Click on the date field (defaults to today's date: Sun Jun 23,
>2019), 
>this displays a calendar
>
>3) Click on the 22nd
>
>4) The resulting date will be Wed Jun 26, 2019
>
>It's not easy to pick the correct date that way ;-)
>
>Tested with 4b0f90ced direct from the oven.
>
>CU
>
>On 22.06.19 21:33, Dirk Hohndel wrote:
>> On Sat, Jun 22, 2019 at 09:14:45PM +0200, Berthold Stoeger wrote:
>>>> 1) See attached image. The default profile of 15m for 45 minutes
>shows a
>>>> crazy profile that is not useful to anybody. The descent rate to
>15m
>>>> should be in the order of 20m/min, NOT 15m/22min. Similarly the
>default
>>>> ascent rate should be around 10m/min. The profile should have a
>square
>>>> shape, not a triangular shape.
>>> That is indeed a bug. Weirdly I get a different profile than what
>you show in
>>> the picture. But when I enter 45 in the duration box a sensible
>profile
>>> appears.
>> What exactly you get depends in part on your settings when you last
>used
>> the planner. I just sent out a pull request that stops using the
>planner
>> to set up that initial dive profile and I think that will address
>this
>> problem in a reasonably clean way.
>>
>>>> 2) The normal red cross-haired cursor and the white points on the
>>>> vertices of the profile are gone so that the default profile cannot
>be
>>>> edited on the profile panel. See section 5.1.1 in user manual.
>>> This is a consequence of the half-baked undo system. To edit the
>profile you
>>> now have to right click on the profile and select "edit profile".
>This will go
>>> into the remnants of the dive edit mode. Perhaps a button should
>appear for
>>> manually entered dives?
>> For people used to the user experience in earlier Subsurface versions
>this
>> may be a bit unintuitive, but once you used the new method once I
>think
>> it's really straight forward. I don't think this deserves another UI
>> element.
>>
>>> Do you think that editing the profile is the common use case? I
>would rather
>>> think that people simply enter date, depth and time, isn't it?
>> This one is interesting. We initially thought that people would
>prefer the
>> graphical dive profile entry and some definitely did. But we got a
>lot of
>> requests to add the text input fields (which initially we didn't have
>-
>> all we had was moving the way points in the profile).
>>
>>> In any case, after adding a dive, the first field, "Date", should be
>selected.
>>> And depth / duration should probably come before the temperature
>fields...
>> As we discussed - there is definitely room for improvement in the way
>we
>> organize / display information on the screen.
>>
>> /D
>> _______________________________________________
>> subsurface mailing list
>> subsurface at subsurface-divelog.org
>>
>http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

-- 
From my phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20190624/7b021d75/attachment.html>