Segfault when removing a cylinder

[Dirk Hohndel]

Hi Gaetan,

Can you check if https://github.com/Subsurface-divelog/subsurface/pull/2406 <https://github.com/Subsurface-divelog/subsurface/pull/2406> fixes
this and comment on that PR with success / failure?

Thanks

/D

> On Nov 26, 2019, at 1:35 PM, Gaetan Bisson <bisson at archlinux.org> wrote:
> 
> Dear all,
> 
> With current git master I'm consistently getting a segfault when trying
> to remove a row from the Cylinders table in the Equipment tab, simply by
> clicking on the trash bin icon.
> 
> The segfault occurs inside CylindersModel::remove(). I do not understand
> much of that code but what I could piece together is the following:
> 
> - index.row() is +1 until the call to endRemoveRows()
> - index.row() becomes -1 after the call to endRemoveRows()
> - std::iota() then segfaults because its second argument is smaller than its first
> 
> Let me know if there's anything I could help test to fix this.
> 
> Cheers.
> 
> -- 
> Gaetan
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20191126/d39e9f44/attachment.html>