Import WLOG no longer working

[Salvador Cuñat]

Hi Dirk.

On Fri, Aug 14, 2020 at 11:53:20AM -0700, Dirk Hohndel wrote:
>
> That's frustrating and shouldn't happen. But the meta data on the cloud server
> show me that Manfred successfully stored data in the cloud from a Windows
> machine earlier today - so I'm not sure that statement is correct, either.
>
I've finally been able to sync Manfred's cloud log in my laptop and
reproduce the segfault.

> Manfred, can you provide some more information what exactly makes
> Subsurface crash for you?
>
This is the backtrace I'm getting:

Thread 1 "subsurface" received signal SIGSEGV, Segmentation fault.
event_renumber (mapping=0x5555592a3400, ev=0x55555906a9b0) at
/home/boret/src/subsurface/core/dive.c:2139
2139        ev->gas.index = mapping[ev->gas.index];
(gdb) bt

#0  event_renumber (mapping=0x5555592a3400, ev=0x55555906a9b0) at
/home/boret/src/subsurface/core/dive.c:2139
#1  event_renumber (mapping=0x5555592a3400, ev=0x55555906a9b0) at
/home/boret/src/subsurface/core/dive.c:2133
#2  dc_cylinder_renumber (dive=0x5555592a3220, dc=0x55555a4efe10,
mapping=0x5555592a3400) at /home/boret/src/subsurface/core/dive.c:2153
#3  0x00005555557faa39 in copy_dc_renumber (cylinders_map=<optimized
out>, ddc=0x55555a4efe10, sdc=0x5555584f5920, d=<optimized out>) at
/home/boret/src/subsurface/core/dive.c:407
#4  join_dive_computers (d=d at entry=0x5555592a3220,
res=res at entry=0x5555592a32d8, a=a at entry=0x5555575d2c08,
b=b at entry=0x5555592a34d8,
cylinders_map_a=cylinders_map_a at entry=0x5555592a3400,
    cylinders_map_b=cylinders_map_b at entry=0x555558ac5e20,
prefer_downloaded=0) at /home/boret/src/subsurface/core/dive.c:2991
#5  0x00005555557fb866 in merge_dives (a=a at entry=0x5555575d2b50,
b=b at entry=0x5555592a3420, offset=offset at entry=0,
prefer_downloaded=prefer_downloaded at entry=false, trip=trip at entry=0x0,
    site=site at entry=0x7fffffffd448) at
/home/boret/src/subsurface/core/dive.c:3095
#6  0x00005555557fc487 in try_to_merge (a=a at entry=0x5555575d2b50,
b=b at entry=0x5555592a3420,
prefer_downloaded=prefer_downloaded at entry=false) at
/home/boret/src/subsurface/core/dive.c:2782
#7  0x0000555555804e8d in try_to_merge_into (table=0x555555ad5b10
<dive_table>, table=0x555555ad5b10 <dive_table>,
dives_to_remove=0x7fffffffd5f0, dives_to_add=0x7fffffffd5e0,
    prefer_imported=false, idx=400, dive_to_add=0x5555592a3420) at
/home/boret/src/subsurface/core/divelist.c:977
#8  merge_dive_tables (dives_from=dives_from at entry=0x7fffffffd6e0,
delete_from=delete_from at entry=0x0,
dives_to=dives_to at entry=0x555555ad5b10 <dive_table>,
    prefer_imported=prefer_imported at entry=false, trip=trip at entry=0x0,
dives_to_add=dives_to_add at entry=0x7fffffffd5e0,
dives_to_remove=0x7fffffffd5f0, num_merged=0x7fffffffd54c)
    at /home/boret/src/subsurface/core/divelist.c:977
#9  0x00005555558054ac in process_imported_dives
(import_table=import_table at entry=0x7fffffffd6e0,
import_trip_table=import_trip_table at entry=0x7fffffffd6f0,
    import_sites_table=import_sites_table at entry=0x7fffffffd700,
flags=flags at entry=4, dives_to_add=dives_to_add at entry=0x7fffffffd5e0,
dives_to_remove=dives_to_remove at entry=0x7fffffffd5f0,
    trips_to_add=0x7fffffffd600, sites_to_add=0x7fffffffd610) at
/home/boret/src/subsurface/core/divelist.c:1261
#10 0x00005555557bba04 in Command::ImportDives::ImportDives
(this=0x555558a31980, dives=0x7fffffffd6e0, trips=0x7fffffffd6f0,
sites=0x7fffffffd700, flags=4, source=...)
    at /home/boret/src/subsurface/commands/command_divelist.cpp:483
#11 0x00005555557b6310 in Command::importDives
(dives=dives at entry=0x7fffffffd6e0, trips=trips at entry=0x7fffffffd6f0,
sites=sites at entry=0x7fffffffd700, flags=flags at entry=4, source=...)
    at /home/boret/src/subsurface/commands/command.cpp:21
#12 0x0000555555697aaa in MainWindow::importFiles (this=<optimized
out>, fileNames=...) at
/home/boret/src/subsurface/desktop-widgets/mainwindow.cpp:1556
#13 0x000055555569fe35 in MainWindow::on_actionImportDiveLog_triggered
(this=0x555555c63f60) at
/usr/include/x86_64-linux-gnu/qt5/QtCore/qstringlist.h:111
#14 0x00005555556c1963 in MainWindow::qt_metacall
(this=0x555555c63f60, _c=QMetaObject::InvokeMetaMethod, _id=36,
_a=0x7fffffffd980)
    at /home/boret/src/subsurface/build/desktop-widgets/subsurface_interface_autogen/EWIEGA46WW/moc_mainwindow.cpp:416
#15 0x00007ffff5e94610 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#16 0x00007ffff74e5ac2 in QAction::triggered(bool) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#17 0x00007ffff74e8301 in QAction::activate(QAction::ActionEvent) ()
from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#18 0x00007ffff766101a in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#19 0x00007ffff7668542 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#20 0x00007ffff752c52e in QWidget::event(QEvent*) () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#21 0x00007ffff74ec03f in QApplicationPrivate::notify_helper(QObject*,
QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#22 0x00007ffff74f1781 in QApplication::notify(QObject*, QEvent*) ()
from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#23 0x00007ffff5e5fb62 in QCoreApplication::notifyInternal2(QObject*,
QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#24 0x00007ffff74f0696 in
QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*,
QWidget*, QWidget**, QPointer<QWidget>&, bool, bool) ()
   from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#25 0x00007ffff754536f in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#26 0x00007ffff75477ae in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#27 0x00007ffff74ec03f in QApplicationPrivate::notify_helper(QObject*,
QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5
#28 0x00007ffff5e5fb62 in QCoreApplication::notifyInternal2(QObject*,
QEvent*) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#29 0x00007ffff68e844b in
QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*)
() from /usr/lib/x86_64-linux-gnu/libQt5Gui.so.5

Best regards.

Salva.