Import WLOG no longer working

Salvador Cuñat salvador.cunat at gmail.com
Fri Aug 14 13:54:25 PDT 2020


Good night.

El vie., 14 ago. 2020 a las 22:27, Linus Torvalds (<
torvalds at linux-foundation.org>) escribió:

> On Fri, Aug 14, 2020 at 12:34 PM Dirk Hohndel <dirk at hohndel.org> wrote:
> >
> > So we are merging dives and are renumbering cylinders, and then things
> go kaboom here:
> >
> > static void event_renumber(struct event *ev, const int mapping[])
> >  ...
> > ev->gas.index = mapping[ev->gas.index];
> >
> > Line 2139 is that last assignment.
> > Since you are compiling from source, Salvador, could you insert an
> fprintf there that prints out the value of and ev->gas.index ?
> > My guess is that that's a bogus value and we are accessing memory we
> should access here.
>

Dive num = 394 -- ev type = 11
ev->gas,index = 1
Dive num = 398 -- ev type = 11
ev->gas,index = 1
Dive num = 401 -- ev type = 25
ev->gas,index = 0
Dive num = 401 -- ev type = 6
Dive num = 401 -- ev type = 3
Dive num = 401 -- ev type = 3
Dive num = 401 -- ev type = 3
Dive num = 401 -- ev type = 6
Dive num = 401 -- ev type = 25
ev->gas,index = 270305728
Violación de segmento

You were right, off course Dirk, look at the last line before the segfault.
I've pasted the previous lines because they are wrong too ... Dive 401 has
just a single event type 25, following events are wrong and, most probably
come from following dives.

But yeah, at a guess the gas.index is some random number and printing
> it out would confirm that.
>
>
Yes, seems completely random.

BTW, Manfred's workflow to add dives to the log is quite unusual and I
think it could be interesting to be considered.  Manfred downloads his
dives on Wlog and then imports the whole file (>1200 dives) in his current
subsurface divelog, so a lot of dives, tanks and events are reworked each
time he does this process. In fact, importing the dives to a xml file,
removing the duplicities and then importing the rest of dives to the
divelog, works like a charm.

Salva.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20200814/20fea2bc/attachment-0001.html>


More information about the subsurface mailing list