Import WLOG no longer working

Berthold Stoeger bstoeger at mail.tuwien.ac.at
Fri Aug 14 23:11:42 PDT 2020


On Freitag, 14. August 2020 22:27:00 CEST Linus Torvalds wrote:

> That said, looking at that commit, I feel I found a completely
> unrelated bug. In "merge_events()" we stop merging aftrer we've done
> *one* event from a divecomputer when we've run out of events from the
> other divecomputer.

You are right. I missed that by assignment the old code copied the whole 
remaining list and not a single event.
 
> Maybe something like the attached, but let's see what Berthold says.

I like that patch - it's pragmatic. I would have added a clone_events() 
function, which would have been much more verbose.

Berthold




More information about the subsurface mailing list