Git-related segfault in master

[Gaetan Bisson]

Hi,

Building today's master (4c5054ec4) on an up-to-date Arch Linux system
(with libgit2-0.28.4) I get a binary which runs fine until it tries to
connect to the cloud service. It then segfaults with the following
backtrace:

#0  0x00007ffff5b05e74 in  () at /usr/lib/libgit2.so.28
#1  0x00007fffef89f182 in http_parser_execute () at /usr/lib/libhttp_parser.so.2.9
#2  0x00007ffff5b07391 in  () at /usr/lib/libgit2.so.28
#3  0x00007ffff5b09771 in  () at /usr/lib/libgit2.so.28
#4  0x00007ffff5b0bb59 in  () at /usr/lib/libgit2.so.28
#5  0x00007ffff5b09f92 in  () at /usr/lib/libgit2.so.28
#6  0x00007ffff5ae6347 in git_remote_fetch () at /usr/lib/libgit2.so.28
#7  0x00005555558745fb in sync_with_remote (rt=RT_HTTPS, branch=0x55555b31cc60 "gaetan at fenua.org", remote=0x55555b31c7c0 "https://cloud.subsurface-divelog.org//git/gaetan@fenua.org", repo=0x55555c97b840) at /opt/arch/aur/subsurface-git/src/subsurface/core/git-access.c:653
#8  sync_with_remote (repo=0x55555c97b840, remote=0x55555b31c7c0 "https://cloud.subsurface-divelog.org//git/gaetan@fenua.org", branch=0x55555b31cc60 "gaetan at fenua.org", rt=RT_HTTPS) at /opt/arch/aur/subsurface-git/src/subsurface/core/git-access.c:598
#9  0x0000555555875aab in update_local_repo (rt=RT_HTTPS, branch=0x55555b31cc60 "gaetan at fenua.org", remote=0x55555b31c7c0 "https://cloud.subsurface-divelog.org//git/gaetan@fenua.org", localdir=0x55555b31d100 "/home/bisson/.subsurface/cloudstorage/831e8034da33af46")
    at /opt/arch/aur/subsurface-git/src/subsurface/core/git-access.c:692
#10 get_remote_repo (branch=0x55555b31cc60 "gaetan at fenua.org", remote=0x55555b31c7c0 "https://cloud.subsurface-divelog.org//git/gaetan@fenua.org", localdir=0x55555b31d100 "/home/bisson/.subsurface/cloudstorage/831e8034da33af46")
    at /opt/arch/aur/subsurface-git/src/subsurface/core/git-access.c:845
#11 is_remote_git_repository (branch=<optimized out>, remote=<optimized out>) at /opt/arch/aur/subsurface-git/src/subsurface/core/git-access.c:933
#12 is_git_repository (filename=<optimized out>, filename at entry=0x55555ac816f8 "https://cloud.subsurface-divelog.org//git/gaetan@fenua.org[gaetan@fenua.org]", branchp=branchp at entry=0x7fffffffdfd8, remote=remote at entry=0x0, dry_run=dry_run at entry=false)
    at /opt/arch/aur/subsurface-git/src/subsurface/core/git-access.c:1004
#13 0x0000555555872c67 in parse_file (filename=0x55555ac816f8 "https://cloud.subsurface-divelog.org//git/gaetan@fenua.org[gaetan@fenua.org]", table=0x555555af5ad0 <dive_table>, trips=0x555555af6080 <trip_table>, sites=0x555555af5a80 <dive_site_table>)
    at /opt/arch/aur/subsurface-git/src/subsurface/core/file.c:305
#14 0x000055555569d938 in MainWindow::loadFiles(QStringList) (this=0x555555e00890, fileNames=...) at /usr/include/qt/QtCore/qarraydata.h:61
#15 0x0000555555689b07 in main(int, char**) (argc=<optimized out>, argv=<optimized out>) at /usr/include/qt/QtCore/qstringlist.h:111

Please tell me it's not just me. :)

Cheers.

-- 
Gaetan