Git-related segfault in master

[Robert Helling]

Hi,

> On 17. Feb 2020, at 07:30, Gaetan Bisson <bisson at archlinux.org <mailto:bisson at archlinux.org>> wrote:
> 
> Building today's master (4c5054ec4) on an up-to-date Arch Linux system
> (with libgit2-0.28.4) I get a binary which runs fine until it tries to
> connect to the cloud service. It then segfaults with the following
> backtrace:
> 
> #0  0x00007ffff5b05e74 in  () at /usr/lib/libgit2.so.28
> #1  0x00007fffef89f182 in http_parser_execute () at /usr/lib/libhttp_parser.so.2.9
> #2  0x00007ffff5b07391 in  () at /usr/lib/libgit2.so.28
> #3  0x00007ffff5b09771 in  () at /usr/lib/libgit2.so.28
> #4  0x00007ffff5b0bb59 in  () at /usr/lib/libgit2.so.28
> #5  0x00007ffff5b09f92 in  () at /usr/lib/libgit2.so.28
> #6  0x00007ffff5ae6347 in git_remote_fetch () at /usr/lib/libgit2.so.28
> #7  0x00005555558745fb in sync_with_remote (rt=RT_HTTPS, branch=0x55555b31cc60 "gaetan at fenua.org <mailto:gaetan at fenua.org>", remote=0x55555b31c7c0 "https://cloud.subsurface-divelog.org//git/gaetan@fenua.org <https://cloud.subsurface-divelog.org//git/gaetan@fenua.org>", repo=0x55555c97b840) at /opt/arch/aur/subsurface-git/src/subsurface/core/git-access.c:653

there were recent changes in the git parsing to fix a problem with bailout events. This seems to be earlier, already in the interaction with the git server. But just to be sure, could you try the commit f6260fff43acc5d4b010f3eb158c2b4533f27367 before Linus’ parsing improvements?

Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20200217/c47c4a4d/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20200217/c47c4a4d/attachment-0001.sig>