Import dives from Cressi Cartesio

[Linus Torvalds]

On Tue, Feb 18, 2020 at 12:20 PM Martin de Weger <martin at deweger.org> wrote:
>
> I’ve downloaded the new version and retried to download the dives. The logfile is attached.

Damn. No change. It still tries the other service.

I wonder what went wrong.  I see that

  Found service "{6e400001-b5a3-f393-e0a9-e50e24dcca9e}" "Unknown Service"

that we _should_ have preferred, but then I see

  Using service "{6e400001-b5a3-f393-e0a9-e50e24dc10b8}" as preferred service

(notice the small difference at the end - they look the same if you
check quickly, but they aren't.

My patch is _so_ simple that I would have expected it to trivially
pick the right one.

I wonder if you re-downloaded the old App. How did you download it?
Because it was only done as a pull request, the normal CI pages won't
get it.

We don't seem to put the git SHA1 commit ID in our normal logs, so I
can't verify. But the _right_ App image should be reachable from:

    https://github.com/Subsurface-divelog/subsurface/pull/2628

and then you have to Click "Details" on the Mac build:

    https://github.com/Subsurface-divelog/subsurface/pull/2628/checks?check_run_id=451424356

and then you have to download it by clicking that "Artifacts" thing in
the upper right hand corner of the build frame, which should get you a
download thing that looks something like

   Download artifacts
    Subsurface.app    279 MB

and now that "Subsurface.app" is the one you want.

If you got it from any other page, it won't contain my little fixlet
for the Cressi Cartesio.

And we definitely should add our version string to the log outputs so
that we can see that it matches the right version. Dirk?

In the meantime, you can check that manually by clicking "Help" and
then "About Subsurface", and you should see the version string.

For that test-build, the version string *should* be

    Subsurface  4.9.3-959-gaa80ecc77ee9

and if it isn't, you're not testing with my Cressi hack in place.

                 Linus