quick update on test binaries

[Dirk Hohndel]

And it turns out that dives/images/wreck.jpg (which is part of the sources) does indeed contain GPS data,
so it's easy for everyone to test this by creating a dive around 2012-01-08 15:51:04

In my brief test on macOS with latest master (4.9.4-80) this appears to work as I would expect.

Thanks Theodor for pointing out the issues and Berthold for immediately fixing them!

/D

> On May 8, 2020, at 8:48 AM, Dirk Hohndel via subsurface <subsurface at subsurface-divelog.org> wrote:
> 
> Apologies. The mailing list is set up to limit mail size (as the mails get send to more than 300 people).
> I had planned to shrink your image, ensuring that the GPS info was retained, and resending it... and got sidetracked and forgot.
> 
> /D
> 
>> On May 7, 2020, at 12:58 PM, Chirana Gheorghita Eugeniu Theodor <office at adaptcom.ro <mailto:office at adaptcom.ro>> wrote:
>> 
>> I think is a problem with one of ny mail. the attached pic waits moserator something.
>> Even with addind a dive site with no gos and adding the pic , did not get any result in populating with gps data.
>> 
>> On Thu, May 7, 2020, 22:32 Chirana Gheorghita Eugeniu Theodor <office at adaptcom.ro <mailto:office at adaptcom.ro>> wrote:
>> And another weird thing:
>> On the added manually dive the time is 1 hour over the local time. Now here is 22:31 and the dive time that is automatically added is 23:31
>> 
>> On Thu, May 7, 2020 at 10:14 PM Chirana Gheorghita Eugeniu Theodor <office at adaptcom.ro <mailto:office at adaptcom.ro>> wrote:
>> Ok did it. no gps data get's asdigned to the dive site. Attached the pic i use
>> 
>> On Thu, May 7, 2020, 21:51 Dirk Hohndel <dirk at hohndel.org <mailto:dirk at hohndel.org>> wrote:
>> 
>> 
>> > On May 7, 2020, at 11:35 AM, Chirana Gheorghita Eugeniu Theodor <office at adaptcom.ro <mailto:office at adaptcom.ro>> wrote:
>> > 
>> > So more testing. As I said with pics it works except for the gps data from pic. I cannot figure how to import that data . 
>> 
>> I personally have never used that (as all of my devices have been set up to NEVER record GPS locations in pictures).
>> It seems to me that in dive.c / create_picture() we are extracting the location from the EXIF information and then call
>> dive_set_geodata_from_picture() - reading that function, what is needed is that your dive does have a location (i.e. a dive_site),
>> but that the dive_site has no GPS data associated with it.
>> 
>> So to test this theory, can you go back, make sure your manually created dive has a dive_site but no GPS, and then add the picture to it?
>> 
>> > I just pened the dive in dive planned, saved the dive, and the description gets populated with the calculated dive plan. I save to cloud and when opening again I see this error on the bottom of the screen:
>> > git-load: string marker after running out of strings ('description')
>> 
>> I have seen this as well and need to figure out why we still show this. I thought we had agreed that this is not an actual error we want to report :-(
>> 
>> > I delete the description , save to cloud, close the app and open again. Same error.
>> > Delete the dive and save to cloud, reopen app and error is gone.
>> > Add dive again manually again save to cloud, close app and reopen and error is gone.
>> > 
>> > So If I open the dive again in planner with no pic attached and save the dive, description gets populated, save to cloud and when opening same error.
>> > Deleting that dive and just typing test.ing word in another dive description, save and close at reopen no more error
>> > Seems it has a issue with description field beeing to long ?
>> 
>> That definitely needs more investigation. I'll try to reproduce
>> 
>> Thank you!
>> 
>> /D
>> 
>> 
>> 
>> -- 
>> ________________________________________
>> Cu stima/Best regards/Mit freundlichen Grüßen,
>> 
>> Chirana-Gheorghita Eugeniu-Theodor
>> Bucharest, Romania
>> 
>> e-mail : office at adaptcom.ro <mailto:office at adaptcom.ro>
>> mobile: 0743 698721
>>             0747 447675
>> SSI diver ID: 1118289
> 
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20200508/37cf35e9/attachment-0001.html>