changes to the mobile builds

Dirk Hohndel dirk at hohndel.org
Sat Nov 21 10:22:31 PST 2020


That's... interesting...

> On Nov 21, 2020, at 10:16 AM, David Tillotson via subsurface <subsurface at subsurface-divelog.org> wrote:
> 
>> Please test these new binaries. Test simple things (can you update
>> cloud storage - do you see the updates on your desktop). Test things
>> we often forget to test (can you get to the user manual? can you edit
>> dives? can you run the GPS service? can you tap on dive locations and
>> get a map?) And of course test downloading from various dive
>> computers.
>> 
>> Especially on Android this is maybe the most significant set of
>> changes that I've made in over a year. I'd really love to not have
>> our end users find all of the bugs that this is causing.
> 
> Just tried some basic checks on my S20+, and found that backing out of
> the add dive page just goes to a blank page. The access to the app log
> still works (although selecting text doesn't function). I've
> transcribed the log text, after retrying without the noise from the
> Bluetooth stack:

The easiest way to do this, btw, is to use the 'copy logs' button in the Help->About page.
That makes it easy to simply paste all of the logs into an email and then edit away what's in the way.

> index 2 select changed to false
> "2.617: pageStack switched to DiveDetails"
> "2.618: switched to page Dive details"
> index 0 select changed to true
> "5.779: endEditMode called with state add"
> "5.804: showProgress: Save changes to local cache"
> "5.806: showProgress: Synchronising data file"
> "5.809: showProgress: Preparing to save data"
> "5.811: showProgress: Start saving data"
> "5.816: showProgress: Start saving dives"
> "5.821: showProgress: Done creating local cache"
> "5.825: pageStack switched to DiveList"
> "5.826: endEditMode called with state add"
> "5.826: showProgress: Save changes to local cache"
> "5.827: showProgress: Synchronising data file"
> "5.829: showProgress: Preparing to save data"
> "5.830: showProgress: Start saving data"
> "5.835: showProgress: Start saving dives"
> "5.838: showProgress: Done creating local cache"
> <Unknown File>:7: TypeError: Cannot read property 'contentX' of null
> qrc:/org/kde/kirigami/private/globaltoolbar/BreadcumbControl.qml:43:
> TypeError: Cannot read property 'x' of undefined
> "5.884: there's no current page"

So that's almost certainly the issue. Our page stack gets confused and we end up
with no page selected. What's even odder is that even tapping on the dive list in
the main menu doesn't get things back where they should be (as you can tell,
based on your report I was able to reproduce the issue).
I'll need to instrument the code some more to figure out what's going on.

Thanks for the test!

/D


More information about the subsurface mailing list