*** SPAM *** (was: Re: fatal error: QPrintDialog: No such file or directory)

[Dirk Hohndel]

> On Oct 10, 2020, at 1:25 PM, Cristian Ionescu-Idbohrn  wrote:
> 
> On Sat, 10 Oct 2020, Robert Helling via subsurface wrote:
>> 
>> This is indeed a result of the recent removal of Grantlee and then 
>> not rerunning cmake.
> 
> Not sure I'm following.
> 
>> In theory that should happen automatically through Makefile 
>> dependency, but my guess is something went wrong there for you ;-)
> 
> Yes.
> 
>> Can you remove your build directory and start again running 
>> subsurface/scripts/build.sh from the directory 'above' the 
>> subsurface directory?
> 
> That's exactly what I did and stated.

I'll try again.

For me, on both Linux and Mac, all I needed to do in the build directory was
to run 'cmake .' and then a make completed fine.
I can also tell from the test builds that a fresh checkout works fine.


>> All the tests passed, but they of course always build from scratch...
> 
> And I did that too.

so you actually do an 'rm -rf subsurface/build' and then run the build script
and you still get that error? That's... puzzling. And rather surprising.

But it's of course entirely possible that I messed something up when making
this change.

Which OS are you? Maybe I can reproduce this and then fix it.

>> as I wrote in the discussion of your pull request, I had the same 
>> error message when running the build script from a fresh checkout 
>> without the —with-webkit option. It should be „no webkit“ => „no 
>> printing“ => this file should not be included.
> 
> That should be clearly documented, else it will confuse people.
> So, what do I need to do besides stating with a clean clone?

You shouldn't need to do anything special. It's supposed to "just work".

/D