fatal error: QPrintDialog: No such file or directory

[Cristian Ionescu-Idbohrn]

On Sun, 11 Oct 2020, Dirk Hohndel wrote:
> 
> I'll try again.

Just did.  Same error:

[ 56%] Building CXX object desktop-widgets/CMakeFiles/subsurface_interface.dir/mainwindow.cpp.o
.../subsurface/desktop-widgets/mainwindow.cpp:59:10: fatal error: QPrintDialog: No such file or directory
   59 | #include <QPrintDialog>
      |          ^~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [desktop-widgets/CMakeFiles/subsurface_interface.dir/build.make:477: desktop-widgets/CMakeFiles/subsurface_interface.dir/mainwindow.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

> For me, on both Linux and Mac, all I needed to do in the build 
> directory was to run 'cmake .' and then a make completed fine.

$ cmake .
CMake Deprecation Warning at CMakeLists.txt:11 (cmake_policy):
  The OLD behavior for policy CMP0071 will be removed from a future version
  of CMake.

  The cmake-policies(7) manual explains that the OLD behaviors of all
  policies are deprecated and that a policy should be set to OLD only under
  specific short-term circumstances.  Projects should be ported to the NEW
  behavior and not rely on setting a policy to OLD.


-- GCC optimization flags: -O2
-- building without usermanual
-- system name Linux
-- Configuring done
-- Generating done
-- Build files have been written to: .../subsurface/build

$ make
[...]
[ 49%] Building CXX object desktop-widgets/CMakeFiles/subsurface_interface.dir/mainwindow.cpp.o
.../subsurface/desktop-widgets/mainwindow.cpp:59:10: fatal error: QPrintDialog: No such file or directory
   59 | #include <QPrintDialog>
      |          ^~~~~~~~~~~~~~
compilation terminated.

> I can also tell from the test builds that a fresh checkout works fine.

Not here :(

[ 56%] Building CXX object desktop-widgets/CMakeFiles/subsurface_interface.dir/mainwindow.cpp.o
/tmp/dive/subsurface/desktop-widgets/mainwindow.cpp:59:10: fatal error: QPrintDialog: No such file or directory
   59 | #include <QPrintDialog>
      |          ^~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [desktop-widgets/CMakeFiles/subsurface_interface.dir/build.make:477: desktop-widgets/CMakeFiles/subsurface_interface.dir/mainwindow.cpp.o] Error 1

> so you actually do an 'rm -rf subsurface/build' and then run the
> build script and you still get that error?

Yes.

> That's... puzzling. And rather surprising.

Yes.

> But it's of course entirely possible that I messed something up when
> making this change.

As mentioned, after checking out commit b3e28eed5d08cbbbcc640875f9b0f2e5f0af3506
builds fine, but commit 7f896ee8d50152e85c6f40ff800c5ad8f9ba4124	
breaks my build with the above error.  It appears this 
/usr/include/x86_64-linux-gnu/qt5/QtPrintSupport header directory is 
missing from the build.

> Which OS are you? Maybe I can reproduce this and then fix it.

Debian unstable or testing.


Cheers,

-- 
Cristian