*** SPAM *** (was: Re: fatal error: QPrintDialog: No such file or directory)

[Robert Helling]

> On 11. Oct 2020, at 12:53, Robert Helling via subsurface <subsurface at subsurface-divelog.org <mailto:subsurface at subsurface-divelog.org>> wrote:
> 
> is it possible that all your builds are with webkit?

Building in a fresh build directory without webkit option I get the error from


#ifndef NO_PRINTING
#include <QPrintDialog>
#include <QBuffer>
#include "desktop-widgets/printdialog.h"
#endif

Somehow, NO_PRINTING seems not to be defined. If I add

#define NO_PRINTING ON

above, the build succeeds.

I must admit, I don’t really understand the relation between environment variables in the build script, variables in cmake and macro definitions in the C source and how one is supposed to influence the other.

My suspicion is that in 7f896ee8d5

diff --git a/cmake/Modules/HandleFindGrantlee.cmake b/cmake/Modules/HandleFindGrantlee.cmake
deleted file mode 100644
index becffd9a8..000000000
--- a/cmake/Modules/HandleFindGrantlee.cmake
+++ /dev/null
@@ -1,19 +0,0 @@
-if(NO_PRINTING)
-       message(STATUS "building without printing support")
-       add_definitions(-DNO_PRINTING)
-       set(GRANTLEE_LIBRARIES "")
-else()
-       if(LIBGRANTLEE_FROM_PKGCONFIG)
-               pkg_config_library(GRANTLEE libgrantlee REQUIRED)

we should have this somewhere else.

Best
Robert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20201011/fdad8222/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20201011/fdad8222/attachment-0001.sig>