Building statistics

Dirk Hohndel dirk at hohndel.org
Fri Jan 1 10:00:19 PST 2021


I don't see this math error here which is weird - even with a completely clean build.
Nor do we see it in the GitHub Action build.

The issue with QtCharts was an oversight on my part. I apparently had this manually fixed at some point and then always benefited from the files being there already (i.e., I never deleted my Subsurface.app bundle between builds).
I just pushed a commit into master that should fix that (tried here with a clean build).

commit 48c3e017d6b2c720e656b072d1be554bb73e3d89 (HEAD -> master, origin/master, origin/HEAD)
Author: Dirk Hohndel <dirk at hohndel.org>
Date:   Fri Jan 1 09:56:58 2021 -0800

    build-system: fix macOS QtCharts QML resources
    
    On macOS the cmake build system doesn't copy the QML resources into the app
    bundle and so we do that manually. I forgot to add that for QtCharts.
    
    Signed-off-by: Dirk Hohndel <dirk at hohndel.org>

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 470ecae0a..4cb3effe1 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -497,6 +497,7 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
        install(CODE "execute_process(COMMAND cp -a ${_qt5Core_install_prefix}/qml/QtQuick.2 ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Resources/qml)")
        install(CODE "execute_process(COMMAND cp -a ${_qt5Core_install_prefix}/qml/QtLocation ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Resources/qml)")
        install(CODE "execute_process(COMMAND cp -a ${_qt5Core_install_prefix}/qml/QtPositioning ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Resources/qml)")
+       install(CODE "execute_process(COMMAND cp -a ${_qt5Core_install_prefix}/qml/QtCharts ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Resources/qml)")
        if(NOT Qt5Core_VERSION VERSION_LESS 5.11.0)
                # and with Qt 5.11 we need another library that isn't copied by macdeployqt
                install(CODE "execute_process(COMMAND rm -rf ${CMAKE_BINARY_DIR}/${APP_BUNDLE_DIR}/Contents/Frameworks/QtPositioningQuick.framework)")




> On Jan 1, 2021, at 9:25 AM, Doug Junkins <douglas.junkins at gmail.com> wrote:
> 
> I ran into the same problems as Robert trying to build the bstoeger-statistics branch on MacOS 10.15.7 with Qt 5.15.2 installed with QtCharts, but haven’t had a chance to dig into the issue yet (other than confirming that adding #include <cmath> fixes the missing std::isnan() reference.)
> 
> -Doug
> 
>> On Jan 1, 2021, at 9:12 AM, Dirk Hohndel via subsurface <subsurface at subsurface-divelog.org <mailto:subsurface at subsurface-divelog.org>> wrote:
>> 
>> Oh yes, all my tests of the statistics code have been on macOS 10.15.
>> 
>> What I think you are seeing is that not all required QML modules and plugins were automatically moved into the app folder.
>> I have a few family things to take care of this morning, but I'll try a clean build and make sure that everything works as designed 
>> 
>> /D
>> 
>> On January 1, 2021 8:29:00 AM PST, Berthold Stoeger via subsurface <subsurface at subsurface-divelog.org <mailto:subsurface at subsurface-divelog.org>> wrote:
>> Hi Robert,
>> 
>> On Freitag, 1. Jänner 2021 16:00:28 CET Robert Helling via subsurface wrote:
>> 
>> First thing I noticed was that the compiler complains about not knowing
>> about std::isnan(). But since there is (and is suggested by the compiler)
>> isnan(), I changed all occurrences in this way. Maybe I am still using an
>> old version of the C++ standard, but this seemed to do the job.
>> 
>> Please try
>> 
>> #include <math.h>
>> 
>> or
>> 
>> #include <cmath>
>> 
>> in the respective files. I'm not sure, but I think that it would be standards-
>> conforming if the first version would not populate the std-namespace and the 
>> second version would not populate the global namespace. However, I doubt that 
>> compilers are that unhelpful, so either should work.
>> 
>> th-nb-tmpmbp05-6766:build Helling$ Subsurface.app/Contents/MacOS/Subsurface
>> MapWidget.qml: cannot find a plugin named: googlemaps
>> 1 ,  "The geoservices provider is not supported."
>> qrc:/qml/MapWidget.qml:24: Error: Cannot assign [undefined] to
>> QDeclarativeGeoMapType* Populating font family aliases took 923 ms. Replace
>> uses of missing font family "'Bookman URW'" with one that exists to avoid
>> this cost. qrc:/qml/statsview.qml:3:1: module "QtCharts" is not installed
>>      import QtCharts 2.0
>>      ^
>> QObject::connect(QtCharts::QChart, StatsView): invalid null parameter
>> Segmentation fault: 11
>> 
>> 
>> I know I have QtCharts installed (at first I had not in my Qt 5.12 that I
>> had used so far and then already cmake complained). But somehow QML refuses
>> to import it. Any ideas how to fix this?
>> 
>> Can't help you with that, sorry. But I'm pretty sure that Dirk tested it on 
>> MacOS.
>> 
>> Berthold
>> subsurface mailing list
>> subsurface at subsurface-divelog.org <mailto:subsurface at subsurface-divelog.org>
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface <http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface>
>> 
>> -- 
>> Sent from my phone
>> _______________________________________________
>> subsurface mailing list
>> subsurface at subsurface-divelog.org <mailto:subsurface at subsurface-divelog.org>
>> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20210101/89141ebc/attachment.htm>


More information about the subsurface mailing list