Accidental file delete on mobile.

[Dirk Hohndel]

> On Jan 18, 2021, at 12:00 AM, Chirana Gheorghita Eugeniu Theodor <office at adaptcom.ro> wrote:
> 
> Hello. OK.
> 
> Discovered something:
> - I add a new dive
> -Save and exit to Dive list
> - Enter that dive again
> - delete it >> all ok.
> 
> - Add a new dive
> - Save and exit to Dive list
> - select another dive and back to dive list
> - Select the newly added dive and back to dive list and tha new dive remains selected
> - Open context menu and hit delete >>> App crashes.. Attached logs.
> 


So I understand what the log tells us... but I cannot figure out how to reproduce the situation.
I followed your steps as exactly as I could. And tried several variations. I tried this on three different Android devices (including two running Android 11) as well as on iOS and mobile-on-desktop.
I simply cannot reproduce the crash.

The log file implied that a QML object was deleted while one of its signal handlers was running. During the dive delete a signal handler for the context menu is running, but I don't see how that object could be deleted.
And because of the undo stack, the dive itself isn't actually deleted, just moved on a different list. The one thing that does get deleted is the delegate that shows the dive in the dive list - but that one doesn't actually have a  signal handler running... because even if you opened the context drawer by press-and-hold on the dive (instead of using the three dots in the lower right corner), the signal handler for that delegate has finished when you open the context menu. And by the time you tap on delete in the context menu, it has definitely completed running.

So... hmm... no idea...

And as I said many times before - fixing bugs I cannot reproduce is incredibly hard :-(

/D

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20210118/488f6896/attachment.htm>