Bug with dive planner UI?

Jay Anchor jay.anchor-subsurface at e257.fi
Wed May 5 10:10:49 PDT 2021


Hi,

It seems that there is a possible bug with dive planner ui, e.g. "Dive 
Plan Details" box is empty and it's impossible to populate with any 
action while planning a dive.

With working version of code, "Dive Plan Details" box is populated 
immediately after hitting "Ctrl-L" and it is changed after every changes 
to dive parameters.

This is on Linux with QT 5.14.2.


This change in behavior has been introduced by following commit (based 
on git bisect):

a0f6b4d0b40aa61f670bb2eee1c898b1942dd42d is the first bad commit
commit a0f6b4d0b40aa61f670bb2eee1c898b1942dd42d
Author: Berthold Stoeger <bstoeger at mail.tuwien.ac.at>
Date:   Sun Feb 28 17:28:09 2021 +0100

     planner: avoid starting unneeded variation thread

     When updating the dive profile, a thread is started to calculate
     plan-variations. This is done even when only editing the profile
     or when variation calculation is disabled by the user. The thread
     then exits if it shouldn't calculate the variations.

     Turn this around: test whether variations should be calculated
     before starting the thread.

     Signed-off-by: Berthold Stoeger <bstoeger at mail.tuwien.ac.at>

  qt-models/diveplannermodel.cpp | 176 
+++++++++++++++++++++--------------------
  1 file changed, 92 insertions(+), 84 deletions(-)


Best regards,
Jay

P.S. Thank you very much for making Subsurface!



More information about the subsurface mailing list