Bug with dive planner UI?

[Jay Anchor]

Hi,

On 07/05/2021 22.32, Robert Helling wrote:
> This should be fixed by 
> https://github.com/subsurface/subsurface/pull/3241 
> 

Thank you, now that particular bug is fixed, but there are other 
inconsistencies and/or new bugs (related to that same change?):

In below "redraw triggered" means changing on  "Dive planner points" 
duration, open circuit to CCR, changing setpoint, etc., e.g. hitting tab 
and moving to next cell / item on UI:

- Toggling "Verbatim dive plan" has no effect to dive plan until redraw 
is triggered

- Toggling "Display plan variations" has no effect to dive plan until 
redraw is triggered

- Changing gas (only singe gas is defined) has no effect to dive plan 
until redraw is triggered, e.g. following series of steps:
    - Start planning deep dive (default gas is AIR)
    - Dive plan for AIR is displayed
    - Change gas to e.g. 10/70, on "Available gasses", this has NO 
EFFECT on dive plan
    - Trigger redraw
    - New plan is displayed with correct gas

With old version, all above works so that all changes are reflected 
immediately on dive plan.  This last issue is quite bad IMHO, because it 
is displaying wrong information (e.g. no information is better than 
stale information, in my opinion).


This testing was done with:

Works ok: 56ffa95459b74e2f28c277d5b6d9b004ef26b240
With Issues: (head) dc645ce8c672af8d8166c27ff581ae44994faf6d

Best regards,
Jay