Contributing

[Mark Stiebel]

Of course I'd find something that appears simple but is trickier than it 
might first seem!

I've create issue #3256 
https://github.com/subsurface/subsurface/issues/3256

Only after sending my email did I actually rebuild after my edits to the 
en_GB translation file to find that I was naive in thinking it was that 
simple :)

The specific case I'm referring to is using en_GB, and for the dive trip 
summary line in the dive list.

------ Original Message ------
From: dirk at hohndel.org
To: "Mark Stiebel" <mark at stiebel.me>; "Mark Stiebel via subsurface" 
<subsurface at subsurface-divelog.org>; subsurface at subsurface-divelog.org
Sent: 27/05/2021 12:39:00 PM
Subject: Re: Contributing

>This is actually one of the trickier things to work on.
>The numerous forms are a bit of a pain to get right. Are you talking 
>about en-US out en-GB?
>And which strings?
>
>I think the best way to do this would be to file an issue on GitHub 
>where you show example strings and then I'll try and point you in the 
>right direction...
>
>/D
>
>On May 26, 2021 4:57:46 PM PDT, Mark Stiebel via subsurface 
><subsurface at subsurface-divelog.org> wrote:
>>
>>I've been looking for a way to ease myself into contributing, and 
>>think I found a straightforward candidate...
>>
>>I noticed that in a lot of the text throughout Subsurface it uses the 
>>old "dive(s)" rather than choosing the singular or plural form. Then I 
>>noticed that this is taken care of, and its just that the en-GB 
>>language files do not have the correct values in the <numerusform> 
>>tags.
>>
>>So, what's the preferred process for me to correct this? Do I just 
>>create a bug ticket on git, create a branch for my fix then a PR?
>>
>>Thx,
>>Mark.
>>
>
>--
>from my phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20210527/3f3a5973/attachment.htm>