<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Robert,<br>
<br>
On 14/10/2014 11:01, Robert Helling wrote:<br>
</div>
<blockquote cite="mid:7E9C7D3E-8D89-4EC9-BC8C-2EFD2B4B4EC7@lmu.de"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
1) The planning of CCR is broken (after reenabling it). It was
working before we started to mess with this CCR sensor code (needs
looking into at some point, but I don’t have that right now, but
might have soon. Also: Not critical as currently disabled anyway)
<div apple-content-edited="true">
<div style="orphans: 2; text-align: -webkit-auto; text-indent:
0px; widows: 2; word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;">
<div style="orphans: 2; text-align: -webkit-auto; text-indent:
0px; widows: 2; word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;">
<div style="color: rgb(0, 0, 0); font-family: Menlo;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
text-transform: none; white-space: normal; word-spacing:
0px; -webkit-text-stroke-width: 0px; orphans: 2;
text-align: -webkit-auto; text-indent: 0px; widows: 2;
word-wrap: break-word; -webkit-nbsp-mode: space;
-webkit-line-break: after-white-space;"><br>
</div>
<div style="orphans: 2; text-align: -webkit-auto;
text-indent: 0px; widows: 2; word-wrap: break-word;
-webkit-nbsp-mode: space; -webkit-line-break:
after-white-space;">2) The code of <span
style="text-align: -webkit-auto;">fill_o2_values() seems
fishy to me: Why is that called for OC dives, anyway and
if it is, why are the last lines excited for OC???</span></div>
</div>
</div>
</div>
</blockquote>
Thank you for spotting this. I have just submitted a patch to
improve this situation. As indicated in the patch message, the po2
values have not been explicitly initialised at the point when this
code executes. po2 is initialised here for both CCR and OC. <br>
<br>
<blockquote cite="mid:7E9C7D3E-8D89-4EC9-BC8C-2EFD2B4B4EC7@lmu.de"
type="cite">
<div apple-content-edited="true">
<div style="orphans: 2; text-align: -webkit-auto; text-indent:
0px; widows: 2; word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;">
<div style="orphans: 2; text-align: -webkit-auto; text-indent:
0px; widows: 2; word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;">
<div style="orphans: 2; text-align: -webkit-auto;
text-indent: 0px; widows: 2; word-wrap: break-word;
-webkit-nbsp-mode: space; -webkit-line-break:
after-white-space;"><span style="text-align:
-webkit-auto;"><br>
</span></div>
<div style="orphans: 2; text-align: -webkit-auto;
text-indent: 0px; widows: 2; word-wrap: break-word;
-webkit-nbsp-mode: space; -webkit-line-break:
after-white-space;"><span style="text-align:
-webkit-auto;">3) Possibly unrelated: I looked into the
xml of the Poseidon MkIV reference dive. That has a
number of missing pressures and some values are NaX.
There seems to be something broken as well.</span></div>
<div style="orphans: 2; text-align: -webkit-auto;
text-indent: 0px; widows: 2; word-wrap: break-word;
-webkit-nbsp-mode: space; -webkit-line-break:
after-white-space;"><span style="text-align:
-webkit-auto;"><br>
</span></div>
</div>
</div>
</div>
</blockquote>
I hope you are talking about the inconsistent pressure data at the
start of the log. If not, please indicate because I have looked but
cannot find this lower down in the log. It takes the dive computer
3-10 seconds to start reporting all parameters. The log starts when
the very first value is reported (in this specific case, depth and
o2sensor1), even though other parameters (o2sensor2, other
pressures, temp, etc) have not been reported yet. Therefore the very
first few log records may contain undefined fields. This is inherent
in the way the MKVI logs dives and will be cleaned up when the log
import code is finalised and integrated within the Subsurface code.<br>
Kind regards,<br>
willem<br>
<br>
</body>
</html>