<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 18, 2014 at 1:14 PM, Miika Turkia <span dir="ltr"><<a href="mailto:miika.turkia@gmail.com" target="_blank">miika.turkia@gmail.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This makes the new filtering unusable so nack from me.<span class=""><font color="#888888"><br><br>miika</font></span><div><div class="h5"><br><div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 18, 2014 at 9:47 AM, Anton Lundin <span dir="ltr"><<a href="mailto:glance@acc.umu.se" target="_blank">glance@acc.umu.se</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Signed-off-by: Anton Lundin <<a href="mailto:glance@acc.umu.se" target="_blank">glance@acc.umu.se</a>><br>
---<br>
qt-ui/simplewidgets.cpp | 6 +-----<br>
1 file changed, 1 insertion(+), 5 deletions(-)<br>
<br>
diff --git a/qt-ui/simplewidgets.cpp b/qt-ui/simplewidgets.cpp<br>
index 0ec03b4..b004664 100644<br>
--- a/qt-ui/simplewidgets.cpp<br>
+++ b/qt-ui/simplewidgets.cpp<br>
@@ -616,10 +616,6 @@ MultiFilter::MultiFilter(QWidget *parent) : QWidget(parent)<br>
int minimumHeight = tagFilter->ui.filterInternalList->height() +<br>
tagFilter->ui.verticalLayout->spacing() * tagFilter->ui.verticalLayout->count();<br>
<br>
- QListView *dummyList = new QListView();<br>
- QStringListModel *dummy = new QStringListModel(QStringList() << "Dummy Text");<br>
- dummyList->setModel(dummy);<br>
-<br>
connect(ui->close, SIGNAL(clicked(bool)), this, SLOT(closeFilter()));<br>
connect(ui->clear, SIGNAL(clicked(bool)), MultiFilterSortModel::instance(), SLOT(clearFilter()));<br>
connect(ui->maximize, SIGNAL(clicked(bool)), this, SLOT(adjustHeight()));<br>
@@ -633,7 +629,7 @@ MultiFilter::MultiFilter(QWidget *parent) : QWidget(parent)<br>
expandedWidget->setLayout(l);<br>
<br>
ui->scrollArea->setWidget(expandedWidget);<br>
- expandedWidget->resize(expandedWidget->width(), minimumHeight + dummyList->sizeHintForRow(0) * 5 );<br>
+ expandedWidget->resize(expandedWidget->width(), minimumHeight );<br>
ui->scrollArea->setMinimumHeight(expandedWidget->height() + 5);<br></blockquote></div></div></div></div></div></div></blockquote><div><br></div><div>Heh, I thinik it's a bad idea, since these dummys are to calculate a sane width for the dialog. <br></div><div>this part, specially : + dummyList->sizeHintForRow(0) * 5 ), wich means "please, give me space for 5 rows of choices" :)<br></div><div>We can't use that without use a dummyModel because we need to have a row to ask for it's size.<br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><div class="h5"><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
connect(MultiFilterSortModel::instance(), SIGNAL(filterFinished()), this, SLOT(filterFinished()));<br>
<span><font color="#888888">--<br>
2.1.0<br>
<br>
_______________________________________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org" target="_blank">subsurface@subsurface-divelog.org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" target="_blank">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br>
</font></span></blockquote></div></div></div></div></div></div>
<br>_______________________________________________<br>
subsurface mailing list<br>
<a href="mailto:subsurface@subsurface-divelog.org">subsurface@subsurface-divelog.org</a><br>
<a href="http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface" target="_blank">http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface</a><br>
<br></blockquote></div></div></div>